Skip to content

[branch-2.10] Fix flaky test - #21135

Merged
codelipenghui merged 3 commits into
apache:branch-2.10from
mattisonchao:fix/test-flaky
Sep 6, 2023
Merged

[branch-2.10] Fix flaky test#21135
codelipenghui merged 3 commits into
apache:branch-2.10from
mattisonchao:fix/test-flaky

Conversation

@mattisonchao

@mattisonchao mattisonchao commented Sep 5, 2023

Copy link
Copy Markdown
Member

Motivation

Fix flaky tests of branch-2.10

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@mattisonchao mattisonchao self-assigned this Sep 5, 2023
@mattisonchao
mattisonchao requested a review from coderzc September 5, 2023 14:52
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Sep 5, 2023

@poorbarcode poorbarcode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test LoadSimulationController also set the arg watch to null, could you fix it too?

@horizonzy horizonzy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codelipenghui
codelipenghui merged commit 1300eb5 into apache:branch-2.10 Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants