Skip to content

[improve][broker] Avoid potential inconsistent topic policy - #21233

Closed
mattisonchao wants to merge 1 commit into
apache:masterfrom
mattisonchao:cleanup/avoid_potential_inconsistent_topic_policy
Closed

[improve][broker] Avoid potential inconsistent topic policy#21233
mattisonchao wants to merge 1 commit into
apache:masterfrom
mattisonchao:cleanup/avoid_potential_inconsistent_topic_policy

Conversation

@mattisonchao

Copy link
Copy Markdown
Member

Motivation

Follow up #21231, avoid getting policy directly by cache in broker service.

Modifications

  • Avoid getting topic policy directly in the broker service. It will leave potential bugs by inconsistent topic policies.
  • Deprecate some methods by undefined exceptions and blocking calls.
    • AbstractTopic#getTopicPolicies();
    • BrokerService#getTopicPolicies(TopicName topicName);
  • Let BrokerService#isAllowAutoSubscriptionCreationAsync use async method to get topic policies.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@mattisonchao mattisonchao self-assigned this Sep 21, 2023
@mattisonchao mattisonchao added category/reliability The function does not work properly in certain specific environments or failures. e.g. data lost and removed category/reliability The function does not work properly in certain specific environments or failures. e.g. data lost labels Sep 21, 2023
@mattisonchao mattisonchao added this to the 3.2.0 milestone Sep 21, 2023
@mattisonchao mattisonchao added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Sep 21, 2023
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant