[fix][test] Fix thread leaks in tests by closing executors properly#21425
Merged
Conversation
lhotari
requested review from
BewareMyPower,
Demogorgon314,
dave2wave,
mattisonchao,
nicoloboschi,
poorbarcode and
tisonkun
October 23, 2023 18:14
Technoboy-
approved these changes
Oct 24, 2023
Demogorgon314
approved these changes
Oct 24, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21425 +/- ##
=============================================
+ Coverage 34.55% 73.27% +38.71%
- Complexity 12083 32573 +20490
=============================================
Files 1711 1888 +177
Lines 130708 140307 +9599
Branches 14245 15420 +1175
=============================================
+ Hits 45172 102811 +57639
+ Misses 79503 29410 -50093
- Partials 6033 8086 +2053
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There are thread leaks in tests caused by executors (thread pools) that aren't shutdown properly.
Modifications
Properly shutdown executors that have been created during test execution.
Documentation
docdoc-requireddoc-not-neededdoc-complete