Skip to content

[fix][test] Fix multiple thread leaks in tests - #21500

Merged
lhotari merged 11 commits into
apache:masterfrom
lhotari:lh-fix-even-more-thread-leaks-in-tests
Nov 2, 2023
Merged

[fix][test] Fix multiple thread leaks in tests#21500
lhotari merged 11 commits into
apache:masterfrom
lhotari:lh-fix-even-more-thread-leaks-in-tests

Conversation

@lhotari

@lhotari lhotari commented Nov 1, 2023

Copy link
Copy Markdown
Member

Motivation

There are thread leaks in tests reported by the thread leak detection added in #21450.

Modifications

Fix multiple thread leaks in unit tests.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari
lhotari force-pushed the lh-fix-even-more-thread-leaks-in-tests branch from bca0597 to 37ac67c Compare November 1, 2023 22:07

@cbornet cbornet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@cbornet

cbornet commented Nov 1, 2023

Copy link
Copy Markdown
Contributor

There's a failing test. Can you check ?

@lhotari

lhotari commented Nov 1, 2023

Copy link
Copy Markdown
Member Author

There's a failing test. Can you check ?

@cbornet there was a flaky test and in addition the JVM crashed due to #19307. I wrote about the JVM crash on the dev mailing list yesterday.

@lhotari
lhotari merged commit c3f954e into apache:master Nov 2, 2023
nborisov pushed a commit to nborisov/pulsar that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants