[fix][test] Fix multiple thread leaks in tests, part 2 - #21513
Merged
lhotari merged 9 commits intoNov 4, 2023
Conversation
lhotari
requested review from
Technoboy-,
cbornet,
mattisonchao,
nicoloboschi and
tisonkun
November 3, 2023 18:20
lhotari
force-pushed
the
lh-fix-even-more-thread-leaks-in-tests-2
branch
from
November 3, 2023 22:38
5d0ae54 to
a832e89
Compare
Codecov Report
@@ Coverage Diff @@
## master #21513 +/- ##
============================================
- Coverage 73.22% 73.20% -0.03%
+ Complexity 32607 32604 -3
============================================
Files 1890 1890
Lines 140444 140451 +7
Branches 15436 15436
============================================
- Hits 102839 102812 -27
- Misses 29504 29542 +38
+ Partials 8101 8097 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattisonchao
approved these changes
Nov 4, 2023
nborisov
pushed a commit
to nborisov/pulsar
that referenced
this pull request
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There are thread leaks in tests reported by the thread leak detection added in #21450.
Modifications
Fix multiple thread leaks in unit tests.
Documentation
docdoc-requireddoc-not-neededdoc-complete