Skip to content

[fix][test] Fix that some test cases are not running as expected on CI#21532

Merged
lhotari merged 1 commit into
apache:masterfrom
equanz:fix_surefire_include
Nov 10, 2023
Merged

[fix][test] Fix that some test cases are not running as expected on CI#21532
lhotari merged 1 commit into
apache:masterfrom
equanz:fix_surefire_include

Conversation

@equanz

@equanz equanz commented Nov 7, 2023

Copy link
Copy Markdown
Contributor

Motivation

It seems some test cases like **/*Test2.java aren't run on the default test lifecycle.
This issue is caused by #10148 .

This issue was fixed by changing test file name as follows. However, some developers committed unexpected file name after them.

Modifications

  • Rename files as expected in config

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: equanz#3

@equanz

equanz commented Nov 9, 2023

Copy link
Copy Markdown
Contributor Author

@lhotari Could you check this changes?

@lhotari lhotari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the rule explicit. What tests are omitted?

Comment thread pom.xml Outdated
@equanz
equanz force-pushed the fix_surefire_include branch from f4adbc4 to f0b8805 Compare November 10, 2023 07:54

@lhotari lhotari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@lhotari

lhotari commented Nov 10, 2023

Copy link
Copy Markdown
Member

/pulsarbot rerun-failure-checks

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #21532 (f0b8805) into master (922525f) will increase coverage by 0.14%.
Report is 12 commits behind head on master.
The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #21532      +/-   ##
============================================
+ Coverage     73.11%   73.25%   +0.14%     
- Complexity    32619    32683      +64     
============================================
  Files          1890     1892       +2     
  Lines        140556   140712     +156     
  Branches      15454    15478      +24     
============================================
+ Hits         102762   103079     +317     
+ Misses        29702    29531     -171     
- Partials       8092     8102      +10     
Flag Coverage Δ
inttests 24.08% <0.00%> (?)
systests 24.70% <0.00%> (-0.01%) ⬇️
unittests 72.54% <81.25%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...a/org/apache/pulsar/client/impl/TableViewImpl.java 86.33% <81.25%> (-0.18%) ⬇️

... and 102 files with indirect coverage changes

@lhotari
lhotari merged commit 77cd942 into apache:master Nov 10, 2023
@equanz
equanz deleted the fix_surefire_include branch November 11, 2023 09:28
nborisov pushed a commit to nborisov/pulsar that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants