[fix][test] Fix that some test cases are not running as expected on CI#21532
Merged
Conversation
Contributor
Author
|
@lhotari Could you check this changes? |
lhotari
requested changes
Nov 9, 2023
lhotari
left a comment
Member
There was a problem hiding this comment.
Please make the rule explicit. What tests are omitted?
equanz
force-pushed
the
fix_surefire_include
branch
from
November 10, 2023 07:54
f4adbc4 to
f0b8805
Compare
Member
|
/pulsarbot rerun-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #21532 +/- ##
============================================
+ Coverage 73.11% 73.25% +0.14%
- Complexity 32619 32683 +64
============================================
Files 1890 1892 +2
Lines 140556 140712 +156
Branches 15454 15478 +24
============================================
+ Hits 102762 103079 +317
+ Misses 29702 29531 -171
- Partials 8092 8102 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It seems some test cases like
**/*Test2.javaaren't run on the default test lifecycle.This issue is caused by #10148 .
This issue was fixed by changing test file name as follows. However, some developers committed unexpected file name after them.
*Test2.javato*Test.javato run all tests correctly #13644Modifications
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: equanz#3