[fix][broker] Delete compacted ledger when topic is deleted - #21745
Merged
Conversation
Technoboy-
reviewed
Dec 18, 2023
coderzc
requested review from
Demogorgon314,
codelipenghui,
gaoran10,
mattisonchao and
poorbarcode
December 27, 2023 01:36
Technoboy-
approved these changes
Dec 27, 2023
| } | ||
| } | ||
|
|
||
| CompletableFuture<Void> cleanCompactedLedger() { |
Contributor
There was a problem hiding this comment.
We have TopicCompactionService now, shall we add an new API to the TopicCompactionService?
Member
Author
There was a problem hiding this comment.
This PR is just to fix this old issue, it needs to be cherry-picked to the release branch, I think we can separately propose a PIP extending TopicCompactionService on the later version.
coderzc
force-pushed
the
fix_delete_compacted_ledger
branch
from
December 27, 2023 09:50
ebe004a to
c9d3068
Compare
BewareMyPower
left a comment
BewareMyPower
left a comment
Contributor
There was a problem hiding this comment.
In addition, to keep the same style, you can use assertEquals instead of Assert.assertEquals.
coderzc
force-pushed
the
fix_delete_compacted_ledger
branch
from
December 28, 2023 05:20
66ecc41 to
5f96de3
Compare
coderzc
force-pushed
the
fix_delete_compacted_ledger
branch
from
December 28, 2023 05:21
5f96de3 to
3a2bf54
Compare
poorbarcode
approved these changes
Dec 28, 2023
dao-jun
approved these changes
Dec 28, 2023
codelipenghui
approved these changes
Dec 28, 2023
BewareMyPower
approved these changes
Dec 29, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Jan 3, 2024
coderzc
added a commit
to coderzc/pulsar
that referenced
this pull request
Jan 4, 2024
This was referenced Jan 4, 2024
Technoboy-
pushed a commit
that referenced
this pull request
Jan 10, 2024
merlimat
pushed a commit
that referenced
this pull request
Jan 11, 2024
coderzc
added a commit
that referenced
this pull request
Jan 11, 2024
(cherry picked from commit 23391d3)
15 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the compacted ledger doesn't delete when the topic is deleted, this will result in many orphaned ledgers, we should delete them.
Modifications
Delete compacted ledger when
__compactioncursor is deleted.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: