[fix][client] Fix wrong results of hasMessageAvailable and readNext after seeking by timestamp

[BewareMyPower]

Motivation

After seeking by timestamp, hasMessageAvailable() and readNext() could return wrong values.

The 1st bug was a regression introduced by
#22201, which modifies startMessageId to seekMessageId before a seek operation is done. However, the previous behavior is also a bug but accidentally works in this case. When seeking by timestamp, the seekMessageId is modified to earliest, which should not be compared with lastMessageIdInBroker because the actual start position is determined by the seek timestamp, not the earliest message id.

The 2nd bug was caused by #9652, when startMessageIdInclusive() is configured to create a reader, it could seek to the position of the latest message when lastDequeuedMessageId is earliest and startMessageId is latest.

Modifications

Add a boolean flag hasSoughtByTimestamp to represent whether the last seek call accepts a timestamp. If it's true, don't take startMessageId into comparison with lastMessageIdInBroker, just compare the mark-delete position and last position in the GetLastMessageId response.

Add testHasMessageAvailableAfterSeekTimestamp to verify the change.

For the readNext call, if the reader has sought by timestamp, don't seek to the latest position in hasMessageAvailable. Modify testReadMessageWithBatchingWithMessageInclusive to verify the fix. However, this patch does not modify the existing behavior when seek is not called because the inclusive reader relies on the implicit seek operation in hasMessageAvailable.

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

[lhotari]

LGTM

[codecov-commenter]

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.76%. Comparing base (bbc6224) to head (a8ba009).
⚠️ Report is 1769 commits behind head on master.

Files with missing lines	Patch %	Lines
...va/org/apache/pulsar/client/impl/ConsumerImpl.java	81.81%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #22363      +/-   ##
============================================
+ Coverage     73.57%   73.76%   +0.18%     
+ Complexity    32624    32340     -284     
============================================
  Files          1877     1886       +9     
  Lines        139502   139445      -57     
  Branches      15299    15287      -12     
============================================
+ Hits         102638   102856     +218     
+ Misses        28908    28635     -273     
+ Partials       7956     7954       -2     

Flag	Coverage Δ
inttests	26.66% <45.45%> (+2.08%)	⬆️
systests	24.34% <45.45%> (+0.01%)	⬆️
unittests	73.05% <81.81%> (+0.20%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...va/org/apache/pulsar/client/impl/ConsumerImpl.java	78.62% <81.81%> (+1.04%)	⬆️

... and 142 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.