Skip to content

[Enhancement]Added a metric for geo replication for tracking replicated subscriptions snapshot timeouts #22381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhotari merged 5 commits into from
Oct 10, 2024
Merged

[Enhancement]Added a metric for geo replication for tracking replicated subscriptions snapshot timeouts #22381

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a18425
Update ReplicatedSubscriptionsController.java
nikam14 Mar 22, 2024
48fe420
Update ReplicatedSubscriptionsController.java
nikam14 Mar 23, 2024
1ea94e7
Merge remote-tracking branch 'origin/master' into fix-21793
lhotari Oct 10, 2024
9515819
Add annotation for PIP-264 / OTel
lhotari Oct 10, 2024
5b69685
Revisit metric name to make it consistent with the other metric name
lhotari Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...n/java/org/apache/pulsar/broker/service/persistent/ReplicatedSubscriptionsController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

import static org.apache.pulsar.common.util.Runnables.catchingAndLoggingThrowables;
import io.netty.buffer.ByteBuf;
import io.prometheus.client.Counter;
import io.prometheus.client.Gauge;
import java.io.IOException;
import java.time.Clock;
Expand Down Expand Up @@ -80,6 +81,14 @@ public class ReplicatedSubscriptionsController implements AutoCloseable, Topic.P
"Counter of currently pending snapshots")
.register();

// timeouts use SnapshotOperationResult.TIMEOUT.attributes on the same metric
@PulsarDeprecatedMetric(
newMetricName = OpenTelemetryReplicatedSubscriptionStats.SNAPSHOT_OPERATION_COUNT_METRIC_NAME)
@Deprecated
private static final Counter timedoutSnapshotsMetric = Counter
Comment thread
lhotari marked this conversation as resolved.
.build().name("pulsar_replicated_subscriptions_timedout_snapshots")
.help("Counter of timed out snapshots").register();

private final OpenTelemetryReplicatedSubscriptionStats stats;

public ReplicatedSubscriptionsController(PersistentTopic topic, String localCluster) {
Expand Down Expand Up @@ -263,6 +272,7 @@ private void cleanupTimedOutSnapshots() {
}

pendingSnapshotsMetric.dec();
timedoutSnapshotsMetric.inc();
var latencyMillis = entry.getValue().getDurationMillis();
stats.recordSnapshotTimedOut(latencyMillis);
it.remove();
Expand Down