Skip to content

[fix][build] Fix networkaddress.cache.negative.ttl config - #22400

Merged
lhotari merged 1 commit into
apache:branch-3.0from
nodece:fix-java.security-conf
Apr 2, 2024
Merged

[fix][build] Fix networkaddress.cache.negative.ttl config#22400
lhotari merged 1 commit into
apache:branch-3.0from
nodece:fix-java.security-conf

Conversation

@nodece

@nodece nodece commented Apr 2, 2024

Copy link
Copy Markdown
Member

Motivation

#21207 introduces the networkaddress.cache.negative.ttl config config, which also introduces a bug that appends the "\" at the end:

2024-04-02T15:00:10,494+0000 [pulsar-perf-producer-exec-1-1] INFO  org.apache.pulsar.testclient.PerformanceProducer - Started performance test thread 0
2024-04-02T15:00:10,671+0000 [pulsar-perf-producer-exec-1-1] WARN  org.apache.pulsar.common.util.netty.DnsResolverUtil - Cannot get DNS TTL settings
java.lang.NumberFormatException: For input string: "1 RUN apt-get -y --purge autoremove"
        at java.lang.NumberFormatException.forInputString(NumberFormatException.java:67) ~[?:?]
        at java.lang.Integer.parseInt(Integer.java:668) ~[?:?]
        at java.lang.Integer.valueOf(Integer.java:973) ~[?:?]
        at java.lang.Integer.decode(Integer.java:1458) ~[?:?]
        at java.util.Optional.map(Optional.java:260) ~[?:?]
        at org.apache.pulsar.common.util.netty.DnsResolverUtil.<clinit>(DnsResolverUtil.java:71) ~[org.apache.pulsar-pulsar-common-3.2.2.jar:3.2.2]
        at org.apache.pulsar.client.impl.ConnectionPool.createAddressResolver(ConnectionPool.java:164) ~[org.apache.pulsar-pulsar-client-original-3.2.2.jar:3.2.2]
        at org.apache.pulsar.client.impl.ConnectionPool.lambda$new$1(ConnectionPool.java:127) ~[org.apache.pulsar-pulsar-client-original-3.2.2.jar:3.2.2]
        at java.util.Optional.orElseGet(Optional.java:364) ~[?:?]
        at org.apache.pulsar.client.impl.ConnectionPool.<init>(ConnectionPool.java:127) ~[org.apache.pulsar-pulsar-client-original-3.2.2.jar:3.2.2]
        at org.apache.pulsar.client.impl.ConnectionPool.<init>(ConnectionPool.java:96) ~[org.apache.pulsar-pulsar-client-original-3.2.2.jar:3.2.2]
        at org.apache.pulsar.client.impl.ConnectionPool.<init>(ConnectionPool.java:91) ~[org.apache.pulsar-pulsar-client-original-3.2.2.jar:3.2.2]
        at org.apache.pulsar.client.impl.PulsarClientImpl.<init>(PulsarClientImpl.java:199) ~[org.apache.pulsar-pulsar-client-original-3.2.2.jar:3.2.2]
        at org.apache.pulsar.client.impl.PulsarClientImpl.<init>(PulsarClientImpl.java:156) ~[org.apache.pulsar-pulsar-client-original-3.2.2.jar:3.2.2]
        at org.apache.pulsar.client.impl.ClientBuilderImpl.build(ClientBuilderImpl.java:65) ~[org.apache.pulsar-pulsar-client-original-3.2.2.jar:3.2.2]
        at org.apache.pulsar.testclient.PerformanceProducer.runProducer(PerformanceProducer.java:519) ~[org.apache.pulsar-pulsar-testclient-3.2.2.jar:3.2.2]
        at org.apache.pulsar.testclient.PerformanceProducer.lambda$main$1(PerformanceProducer.java:351) ~[org.apache.pulsar-pulsar-testclient-3.2.2.jar:3.2.2]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) ~[?:?]
        at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[io.netty-netty-common-4.1.105.Final.jar:4.1.105.Final]
        at java.lang.Thread.run(Thread.java:840) ~[?:?]
2024-04-02T15:00:10,763+0000 [pulsar-perf-producer-exec-1-1] INFO  org.apache.pulsar.testclient.PerformanceProducer - Adding 1 publishers on topic my-tenant/my-namespace/rg-test-1

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Apr 2, 2024
@nodece
nodece requested a review from lhotari April 2, 2024 16:13
@nodece nodece self-assigned this Apr 2, 2024
@nodece

nodece commented Apr 2, 2024

Copy link
Copy Markdown
Member Author

/pulsarbot rerun-failure-checks

@lhotari lhotari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari
lhotari merged commit be012c8 into apache:branch-3.0 Apr 2, 2024
lhotari pushed a commit that referenced this pull request Apr 2, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit be012c8)
lhotari pushed a commit that referenced this pull request Apr 2, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit be012c8)
@lhotari

lhotari commented Apr 2, 2024

Copy link
Copy Markdown
Member

#21207 introduces the networkaddress.cache.negative.ttl config config, which also introduces a bug that appends the "" at the end:

The problem existed before that, but in a different way. The problem has been present since Pulsar 3.0.0 . See https://github.com/apache/pulsar/blame/55788734a53acd505d97e6f8b3b4bd567603d9ce/docker/pulsar/Dockerfile#L81 . In #21207, the same pattern was replicated.

This problem only became visible after #22329 changes before that, the DNS settings haven't simply been the expected ones. That might have caused quite a lot of problems.

nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 3, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit be012c8)
(cherry picked from commit 20d35f1)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 4, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit be012c8)
(cherry picked from commit 20d35f1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants