[improve][ml] Optimize read entries with skipCondition - #22560
Open
dao-jun wants to merge 36 commits into
Open
Conversation
# Conflicts: # managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java
dao-jun
added
area/ML
category/performance
dao-jun
changed the title
dao-jun
changed the title
dao-jun
marked this pull request as ready for review
April 25, 2024 08:18
dao-jun
requested review from
codelipenghui,
coderzc,
lhotari,
merlimat,
poorbarcode and
rdhabalia
April 25, 2024 08:18
Member
|
@dao-jun Please rebase once again |
lhotari
added
release/4.0.9
release/4.1.3
and removed
release/4.0.8
release/4.1.2
labels
Member
|
@dao-jun Please rebase once again |
Member
Author
|
@lhotari will do next few days, I'm working on kafka with bookkeeper now |
lhotari
added
release/4.0.10
release/4.1.4
and removed
release/4.0.9
release/4.1.3
labels
# Conflicts: # managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java # managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java # managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java # managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java
Member
Author
|
@lhotari Rebased, PTAL |
Denovo1998
suggested changes
Mar 8, 2026
lhotari
reviewed
Mar 9, 2026
# Conflicts: # managed-ledger/pom.xml
Member
Author
|
@lhotari @Denovo1998 The branch updated, PTAL |
# Conflicts: # managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java # managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In #19035 we introduced
skipConditionto filter-out delay delivery messages before read entries from Bookkeeper, and in #21739, we also filter-out deleted(individual acked messages) before read entries.However, it will lead to one situation: one single segment can be spit into segments. For example:
entries to be filter-out: [3, 5, 7]
entries to read: [1, 10]
then, it will be split into: [[1,2],[4], [6], [8,10]].
In the current implementation, after read [1,2] finished, then begin to read [4], after read [4] finished, then start to read [6]...
It will lead to latency increasing, memory(allocated for entries) will also be retained for a longer period of time, and affect the throughput of the system.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: