[fix] [broker] [Namespace-level Geo-Replication] Reject a topic creation if there is a confilct topic on the remote side - #22577
Open
poorbarcode wants to merge 1 commit into
Conversation
poorbarcode
requested review from
Demogorgon314,
Technoboy-,
gaoran10 and
shibd
April 24, 2024 15:39
Technoboy-
approved these changes
Apr 25, 2024
Member
|
I think we intentionally overlooked the result of creating a topic for the remote cluster. This PR may break the user's behavior of creating topic. According to your description, when using the default broker configuration, and the geo-replication is enabled on the namespace level, the remote cluster will create two non-partitioned topics, tenant/namespace/topic-partition-1 and tenant/namespace/topic-partition-2 by the geo producer. Is it right? If right, I would suggest adding a topic check before starting the replicator to make sure that the topic is the same between local and remote clusters, if they are the same, start the replicator, otherwise throw a log. You can also add this check in the replicator task. |
poorbarcode
force-pushed
the
fix/ns_geo_create_topics
branch
from
April 25, 2024 06:57
a60407e to
0e13f60
Compare
Contributor
Author
|
Rebase master |
nodece
approved these changes
Apr 25, 2024
shibd
approved these changes
Apr 25, 2024
…there is a confilct topic on the remote side
poorbarcode
force-pushed
the
fix/ns_geo_create_topics
branch
from
April 29, 2024 06:09
0e13f60 to
d0963b6
Compare
Contributor
Author
|
Rebase master |
codelipenghui
approved these changes
May 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The steps to describe the issue
1. And the source cluster does not have this topic.3partitions on the source cluster.Modifications
Reject a topic creation if there is a conflict topic on the remote side
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x