Skip to content

[improve][test] Restart broker in SimpleProducerConsumerTest if ns deletion times out - #22734

Merged
Technoboy- merged 1 commit into
apache:masterfrom
lhotari:lh-mitigate-flaky-SimpleProducerConsumerTest
May 20, 2024
Merged

[improve][test] Restart broker in SimpleProducerConsumerTest if ns deletion times out#22734
Technoboy- merged 1 commit into
apache:masterfrom
lhotari:lh-mitigate-flaky-SimpleProducerConsumerTest

Conversation

@lhotari

@lhotari lhotari commented May 17, 2024

Copy link
Copy Markdown
Member

Fixes #20553

Motivation

SimpleProducerConsumerTest is flaky. deleteNamespaceWithRetry often times out. It seems that this became more flaky after #22627.

Modifications

  • When the timeout happens, restart the broker.
  • rename the method rest() to cleanupAfterMethod()
  • capture a thread dump to find out if there's a deadlock when the timeout happens

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.4.0 milestone May 17, 2024
@lhotari
lhotari requested review from coderzc and poorbarcode May 17, 2024 06:55
@lhotari lhotari self-assigned this May 17, 2024
@lhotari
lhotari force-pushed the lh-mitigate-flaky-SimpleProducerConsumerTest branch from 5aae50f to 881c73c Compare May 17, 2024 06:55
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label May 17, 2024
@lhotari

lhotari commented May 17, 2024

Copy link
Copy Markdown
Member Author

Similar problem in #22736

@lhotari
lhotari requested a review from Technoboy- May 17, 2024 12:59
@Technoboy-
Technoboy- merged commit 47fd1a3 into apache:master May 20, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test type/flaky-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky-test: SimpleProducerConsumerTest.rest

2 participants