[improve][broker] Remove ClassLoaderSwitcher to avoid objects allocations and consistent the codestyle - #22796
Merged
Conversation
14 tasks
coderzc
approved these changes
May 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22796 +/- ##
============================================
- Coverage 73.57% 73.22% -0.35%
Complexity 32624 32624
============================================
Files 1877 1890 +13
Lines 139502 141628 +2126
Branches 15299 15540 +241
============================================
+ Hits 102638 103708 +1070
- Misses 28908 29928 +1020
- Partials 7956 7992 +36
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
|
Object allocations are not a big deal here. The main purpose is that you wanna align the code style, right? |
mattisonchao
approved these changes
May 29, 2024
Member
Author
Yes, Protocol handler and AdditionalServlet is not in the message publish/consume calling chain, and they don't call frequently, the PR just consistent the codestyle. |
Member
Author
|
merging.. |
Technoboy-
pushed a commit
that referenced
this pull request
May 30, 2024
…ions and consistent the codestyle (#22796)
Technoboy-
pushed a commit
that referenced
this pull request
May 30, 2024
…ions and consistent the codestyle (#22796)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 31, 2024
…ions and consistent the codestyle (apache#22796) (cherry picked from commit 7918ed5)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2024
…ions and consistent the codestyle (apache#22796) (cherry picked from commit 7918ed5)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2024
…ions and consistent the codestyle (apache#22796) (cherry picked from commit 7918ed5)
Technoboy-
pushed a commit
that referenced
this pull request
Jun 6, 2024
…ions and consistent the codestyle (#22796)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 7, 2024
…ions and consistent the codestyle (apache#22796) (cherry picked from commit 7918ed5)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…ions and consistent the codestyle (apache#22796)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Apply #22790 's pattern and address the comment #22767 (comment)
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: