[fix] [broker] response not-found error if topic does not exist when calling getPartitionedTopicMetadata by poorbarcode · Pull Request #22838 · apache/pulsar

poorbarcode · 2024-06-04T08:13:06Z

Motivation & Modifications

Section Instead of returning a 0 partitioned metadata, respond to a not found error when calling pulsarClient.getPartitionsForTopic(String) if the topic does not exist.

Main PIP: PIP-344 Correct the behavior of the public API pulsarClient.getPartitionsForTopic(topicName)

Documentation

doc
doc-required
doc-not-needed
doc-complete

Matching PR in forked repository

PR in forked repository: x

poorbarcode · 2024-06-04T08:13:57Z

/pulsarbot rerun-failure-checks

…calling getPartitionedTopicMetadata

codecov-commenter · 2024-06-11T04:09:50Z

Codecov Report

Attention: Patch coverage is 80.00000% with 35 lines in your changes missing coverage. Please review.

Project coverage is 73.26%. Comparing base (bbc6224) to head (3e061cc).
Report is 369 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #22838      +/-   ##
============================================
- Coverage     73.57%   73.26%   -0.31%     
- Complexity    32624    33033     +409     
============================================
  Files          1877     1892      +15     
  Lines        139502   142015    +2513     
  Branches      15299    15576     +277     
============================================
+ Hits         102638   104047    +1409     
- Misses        28908    29949    +1041     
- Partials       7956     8019      +63

Flag	Coverage Δ
inttests	`27.35% <54.28%> (+2.76%)`	⬆️
systests	`24.69% <24.57%> (+0.37%)`	⬆️
unittests	`72.30% <80.00%> (-0.55%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...pulsar/broker/admin/impl/PersistentTopicsBase.java	`69.73% <100.00%> (+4.27%)`	⬆️
...he/pulsar/broker/admin/v2/NonPersistentTopics.java	`63.87% <100.00%> (+2.40%)`	⬆️
...g/apache/pulsar/broker/lookup/TopicLookupBase.java	`75.84% <100.00%> (+8.42%)`	⬆️
...apache/pulsar/client/impl/ConsumerBuilderImpl.java	`86.69% <85.71%> (-0.25%)`	⬇️
...va/org/apache/pulsar/broker/service/ServerCnx.java	`72.14% <66.66%> (-0.01%)`	⬇️
...pache/pulsar/broker/namespace/TopicExistsInfo.java	`79.48% <79.48%> (ø)`
...rg/apache/pulsar/broker/service/BrokerService.java	`82.14% <77.14%> (+1.36%)`	⬆️
...ache/pulsar/broker/namespace/NamespaceService.java	`73.15% <72.50%> (+0.91%)`	⬆️

... and 384 files with indirect coverage changes

poorbarcode · 2024-06-11T08:42:32Z

@lhotari Could you take a look at your convenience

The review has been no response for a long time

…calling getPartitionedTopicMetadata (#22838) (cherry picked from commit 9aed736)

…calling getPartitionedTopicMetadata (apache#22838) (cherry picked from commit 9aed736) (cherry picked from commit 1d2959b)

…calling getPartitionedTopicMetadata (#22838) (cherry picked from commit 9aed736)

…calling getPartitionedTopicMetadata (apache#22838) (cherry picked from commit 9aed736) (cherry picked from commit 1d2959b)

…calling getPartitionedTopicMetadata (apache#22838)

…calling getPartitionedTopicMetadata (apache#22838) (cherry picked from commit 9aed736) Signed-off-by: Zixuan Liu <nodeces@gmail.com>

* [fix] [broker] response not-found error if topic does not exist when calling getPartitionedTopicMetadata (apache#22838) (cherry picked from commit 9aed736) Signed-off-by: Zixuan Liu <nodeces@gmail.com> * [fix] [broker] Fix compatibility issues for PIP-344 (apache#23136) Co-authored-by: Lari Hotari <lhotari@apache.org> (cherry picked from commit 702c0b3) Signed-off-by: Zixuan Liu <nodeces@gmail.com> * Fix test Signed-off-by: Zixuan Liu <nodeces@gmail.com> * Fix test Signed-off-by: Zixuan Liu <nodeces@gmail.com> * Fix test Signed-off-by: Zixuan Liu <nodeces@gmail.com> * Disable testTopicPoliciesWithMultiBroker Signed-off-by: Zixuan Liu <nodeces@gmail.com> --------- Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: fengyubiao <yubiao.feng@streamnative.io> Co-authored-by: Lari Hotari <lhotari@apache.org>

…osition implementation for compaction (streamnative#606) ### Motivation apache/pulsar#22891 introduces some changes for the PositionImpl. Now we need to use the Position interface instead of the PositionImpl. ### Modifications - Refactor to use Position instead of PositionImpl - apache/pulsar#22572 uses `getLastDispatchablePosition` instead of `getMaxPosition` to return the last message id, this patch implements the new method for `KopPersistentTopic`. - apache/pulsar#22838 changed the result for `checkTopicExists`. This PR also adapts to changes. - apache/pulsar#22882 removed the method `org.apache.pulsar.broker.service.Producer.updateRates(int numOfMessages, long msgSizeInBytes)`. We need to use `producer.getStats().recordMsgIn` instead. --------- Co-authored-by: Yunze Xu <xyzinfernity@163.com>

poorbarcode requested review from Technoboy-, codelipenghui and gaoran10 June 4, 2024 08:13

poorbarcode self-assigned this Jun 4, 2024

poorbarcode added this to the 3.4.0 milestone Jun 4, 2024

github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Jun 4, 2024

poorbarcode added ready-to-test and removed doc-not-needed Your PR changes do not impact docs labels Jun 4, 2024

github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Jun 4, 2024

lhotari previously requested changes Jun 4, 2024

View reviewed changes

Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/TopicExistsInfo.java Outdated

lhotari reviewed Jun 4, 2024

View reviewed changes

Comment thread pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java Outdated

poorbarcode requested a review from lhotari June 6, 2024 08:58

poorbarcode added 15 commits June 11, 2024 10:50

[fix] [broker] response not-found error if topic does not exist when …

24959d0

…calling getPartitionedTopicMetadata

checkstyle

06a0b15

fix test

bc5bcea

addrees comment

653272f

address comment

08f02a4

fix tests

f209eab

fix tests

d111bd2

fix tests

3911aba

fix tests

02416de

add a test case: topic with suffix -partition-1

3bdfe97

add a test case: topic with suffix -partition-1

f0677a9

fix tests

dab61e1

fix compatibility for old DLQ

ba0d3e6

checkstyle

4b5fb5d

fix tests

3e061cc

poorbarcode force-pushed the pip_344/part_4 branch from b7ce67c to 3e061cc Compare June 11, 2024 02:51

add code description

a244d98

poorbarcode requested a review from Technoboy- June 11, 2024 08:11

check style

346adcc

Technoboy- approved these changes Jun 11, 2024

View reviewed changes

poorbarcode requested review from lhotari and removed request for lhotari June 11, 2024 08:42

poorbarcode merged commit 9aed736 into apache:master Jun 17, 2024

poorbarcode added a commit that referenced this pull request Jun 19, 2024

[fix] [broker] response not-found error if topic does not exist when …

1d2959b

…calling getPartitionedTopicMetadata (#22838) (cherry picked from commit 9aed736)

poorbarcode added cherry-picked/branch-3.0 release/3.0.6 labels Jun 19, 2024

shibd added the release/important-notice The changes which are important should be mentioned in the release note label Jun 28, 2024

poorbarcode added a commit that referenced this pull request Jun 28, 2024

[fix] [broker] response not-found error if topic does not exist when …

7270598

…calling getPartitionedTopicMetadata (#22838) (cherry picked from commit 9aed736)

poorbarcode added release/3.3.1 cherry-picked/branch-3.3 labels Jun 28, 2024

shibd mentioned this pull request Jul 2, 2024

[fix][broker] Can't connecte to non-persist topic when enable broker client tls #22991

Merged

4 tasks

poorbarcode mentioned this pull request Aug 7, 2024

[fix] [broker] Fix compatibility issues for PIP-344 #23136

Merged

4 tasks

hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025

[fix] [broker] response not-found error if topic does not exist when …

e3214c3

…calling getPartitionedTopicMetadata (apache#22838)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[fix] [broker] response not-found error if topic does not exist when calling getPartitionedTopicMetadata - #22838

[fix] [broker] response not-found error if topic does not exist when calling getPartitionedTopicMetadata#22838
poorbarcode merged 20 commits into
apache:masterfrom
poorbarcode:pip_344/part_4

poorbarcode commented Jun 4, 2024 •

edited

Loading

Uh oh!

poorbarcode commented Jun 4, 2024

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Jun 11, 2024

Uh oh!

poorbarcode commented Jun 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

poorbarcode commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation & Modifications

Documentation

Matching PR in forked repository

Uh oh!

poorbarcode commented Jun 4, 2024

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Jun 11, 2024

Codecov Report

Uh oh!

poorbarcode commented Jun 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

poorbarcode commented Jun 4, 2024 •

edited

Loading