Skip to content

[fix][test] Flaky-test: CurrentLedgerRolloverIfFullTest.testCurrentLedgerRolloverIfFull #23221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marekczajkowski wants to merge 1 commit into from
Closed

[fix][test] Flaky-test: CurrentLedgerRolloverIfFullTest.testCurrentLedgerRolloverIfFull #23221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ...roker/src/test/java/org/apache/pulsar/broker/service/CurrentLedgerRolloverIfFullTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
*/
package org.apache.pulsar.broker.service;

import static org.awaitility.Awaitility.await;

import java.lang.reflect.Field;
import java.time.Duration;
import java.util.concurrent.TimeUnit;
Expand Down Expand Up @@ -81,7 +83,8 @@ public void testCurrentLedgerRolloverIfFull() throws Exception {
}

ManagedLedgerImpl managedLedger = (ManagedLedgerImpl) persistentTopic.getManagedLedger();
Assert.assertEquals(managedLedger.getLedgersInfoAsList().size(), msgNum / 2);
// 10 msg, 2 entries per ledger. 5 is full, another one is created. Await to avoid race condition
await().until(() -> managedLedger.getLedgersInfoAsList().size() == 6); //

for (int i = 0; i < msgNum; i++) {
Message<byte[]> msg = consumer.receive(2, TimeUnit.SECONDS);
Expand All @@ -91,7 +94,7 @@ public void testCurrentLedgerRolloverIfFull() throws Exception {

// all the messages have been acknowledged
// and all the ledgers have been removed except the the last ledger
Awaitility.await()
await()
.pollInterval(Duration.ofMillis(500L))
.untilAsserted(() -> {
Assert.assertEquals(managedLedger.getLedgersInfoAsList().size(), 1);
Expand All @@ -105,7 +108,7 @@ public void testCurrentLedgerRolloverIfFull() throws Exception {
managedLedger.rollCurrentLedgerIfFull();

// the last ledger will be closed and removed and we have one ledger for empty
Awaitility.await()
await()
.pollInterval(Duration.ofMillis(1000L))
.untilAsserted(() -> {
Assert.assertEquals(managedLedger.getLedgersInfoAsList().size(), 1);
Expand Down