Skip to content

[improve][pip] PIP-377: Automatic retry for failed acknowledgements - #23267

Closed
lhotari wants to merge 3 commits into
apache:masterfrom
lhotari:lh-pip-377-autoRetryAcknowledgement
Closed

[improve][pip] PIP-377: Automatic retry for failed acknowledgements#23267
lhotari wants to merge 3 commits into
apache:masterfrom
lhotari:lh-pip-377-autoRetryAcknowledgement

Conversation

@lhotari

@lhotari lhotari commented Sep 7, 2024

Copy link
Copy Markdown
Member

Motivation

In the pip-377.md file

Modifications

In the pip-377.md file

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.0.0 milestone Sep 7, 2024
@lhotari lhotari self-assigned this Sep 7, 2024
@github-actions github-actions Bot added PIP doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. labels Sep 7, 2024
@aloyszhang

Copy link
Copy Markdown
Contributor

Is there a precise step to reproduce the acknowledgment lost?

@lhotari

lhotari commented Sep 12, 2024

Copy link
Copy Markdown
Member Author

Is there a precise step to reproduce the acknowledgment lost?

@aloyszhang not yet, there's #22709 and #21958 where it seems that acks get lost.

One possible way that acks could get lost is due to the issue described in #23200 where the number of ack holes exceeds the default limit of 10000. If the the consumer gets reconnected at this time (client connection breaks or due to load balancing event), acks would get lost.
There was a previous attempt to limit the number of ack holes with PIP-299. The problem is that it won't prevent exceeding the limit. The problem described in #23200 is addressed with #23231 (which I'm currently working on).

@lhotari

lhotari commented Jun 1, 2026

Copy link
Copy Markdown
Member Author

#25525 makes this obsolete and addresses the actual issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. PIP ready-to-test release/4.0.11 release/4.2.2 type/PIP

Development

Successfully merging this pull request may close these issues.

4 participants