[improve][broker] PIP-376: Make topic policies service pluggable#23319
Merged
BewareMyPower merged 3 commits intoSep 19, 2024
Merged
Conversation
github-actions
Bot
added
the
doc
BewareMyPower
requested review from
RobertIndie,
codelipenghui,
dao-jun,
eolivelli and
lhotari
September 19, 2024 09:10
lhotari
approved these changes
Sep 19, 2024
lhotari
left a comment
lhotari
left a comment
Member
There was a problem hiding this comment.
LGTM. Good work @BewareMyPower!
Contributor
Author
|
The latest commit might cause some infinite loops. Let me investigate the failed tests. |
BewareMyPower
marked this pull request as draft
September 19, 2024 10:12
…is empty or deleted
BewareMyPower
marked this pull request as ready for review
September 19, 2024 10:42
4 tasks
BewareMyPower
deleted the
bewaremypower/pluggable-topic-policies-service
branch
September 21, 2024 07:08
2 tasks
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PIP: #23248
Modifications
Adapting to the new interface according to the PIP documents.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: BewareMyPower#35