[fix][broker] Avoid introducing delay when there are delayed messages or marker messages - #23343
Merged
Merged
Conversation
lhotari
requested review from
codelipenghui,
dao-jun,
dlg99,
eolivelli,
equanz,
merlimat,
poorbarcode and
shibd
September 24, 2024 10:38
codelipenghui
approved these changes
Sep 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23343 +/- ##
============================================
+ Coverage 73.57% 74.56% +0.99%
- Complexity 32624 34443 +1819
============================================
Files 1877 1934 +57
Lines 139502 144990 +5488
Branches 15299 15838 +539
============================================
+ Hits 102638 108116 +5478
+ Misses 28908 28591 -317
- Partials 7956 8283 +327
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
… or marker messages (apache#23343)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR #23226 introduced a change to introduce a delay before calling
readMoreEntriesin PersistentDispatcherMultipleConsumers classes when no messages were dispatched.This logic didn't take into account the case when all messages are delayed messages, marker messages or messages from an aborted transaction. In those cases additional delays would be introduced, causing performance regressions.
Modifications
lastNumberOfEntriesProcessedtracks how many entries were processed by consumers in the lasttrySendMessagesToConsumerscalltrySendMessagesToConsumerscall. Only in those cases should the retry happen after a delay with increasing backoff.Documentation
docdoc-requireddoc-not-neededdoc-complete