[improve][broker] check system topic is used before configuring system topic (ExtensibleLoadManagerImpl only) - #23381
Merged
heesung-sohn merged 1 commit intoOct 1, 2024
Conversation
|
@heesung-sn Please add the following content to your PR description and select a checkbox: |
heesung-sohn
requested review from
BewareMyPower,
Demogorgon314 and
codelipenghui
and removed request for
Demogorgon314
September 30, 2024 22:49
codelipenghui
approved these changes
Sep 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23381 +/- ##
============================================
+ Coverage 73.57% 74.51% +0.93%
- Complexity 32624 34471 +1847
============================================
Files 1877 1934 +57
Lines 139502 145139 +5637
Branches 15299 15870 +571
============================================
+ Hits 102638 108149 +5511
+ Misses 28908 28691 -217
- Partials 7956 8299 +343
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…m topic (ExtensibleLoadManagerImpl only) (apache#23381)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR(#23301) introduces the ServiceUnitStateMetadataStoreTableView, which persists ownership information in metadata store. When this is used, we don't need to configure system topic in the monitor thread. Currently, the monitor thread unnecessarily tries to configure the system topic and prints red-herring error logs
Failed to set compaction threshold for system topic:persistent://pulsar/system/loadbalancer-service-unit-stateModifications
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: