Skip to content

[fix][broker][branch-3.3] Fix unloadNamespaceBundlesGracefully can be stuck with extensible load manager (#23349) - #23496

Merged
BewareMyPower merged 2 commits into
apache:branch-3.3from
heesung-sohn:branch-3.3-cherry-pick
Oct 23, 2024
Merged

[fix][broker][branch-3.3] Fix unloadNamespaceBundlesGracefully can be stuck with extensible load manager (#23349)#23496
BewareMyPower merged 2 commits into
apache:branch-3.3from
heesung-sohn:branch-3.3-cherry-pick

Conversation

@heesung-sohn

@heesung-sohn heesung-sohn commented Oct 22, 2024

Copy link
Copy Markdown
Contributor

(cherry picked from commit e91574a)

I need to export some of the changes in #23301 to resolve conflicts.

fork-test: heesung-sohn#83

@github-actions

Copy link
Copy Markdown

@heesung-sn Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@BewareMyPower BewareMyPower added doc-not-needed Your PR changes do not impact docs ready-to-test labels Oct 23, 2024
@heesung-sohn
heesung-sohn force-pushed the branch-3.3-cherry-pick branch from 3f5fb9f to 483c343 Compare October 23, 2024 04:13
@heesung-sohn

heesung-sohn commented Oct 23, 2024

Copy link
Copy Markdown
Contributor Author

I added this change in this PR, 3b9e857 to handle ClusterMigrationTest.testClusterMigrationWithReplicationBacklog failure.

Regarding ClusterMigrationTest.testClusterMigrationWithReplicationBacklog failure, the root cause is that after the broker is disabled, the assignment operation couldn't complete, and its lookup timed out. To handle this, we don't allow assignment when the broker is disabled.

However, this test passes in the master branch now without this change.

@BewareMyPower
BewareMyPower merged commit d42dacb into apache:branch-3.3 Oct 23, 2024
@heesung-sohn
heesung-sohn deleted the branch-3.3-cherry-pick branch October 23, 2024 11:28
@lhotari lhotari changed the title [fix][broker] Fix unloadNamespaceBundlesGracefully can be stuck with extensible load manager (#23349) [fix][broker][branch-3.3] Fix unloadNamespaceBundlesGracefully can be stuck with extensible load manager (#23349) Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants