[improve][broker] Reduce memory occupation of the delayed message queue#23611
Merged
thetumbled merged 8 commits intoNov 22, 2024
Merged
Conversation
thetumbled
requested review from
BewareMyPower,
coderzc,
dao-jun,
lhotari,
mattisonchao and
poorbarcode
November 19, 2024 08:29
Member
|
Good work, and I'm just wandering how much memories can we reduce? |
Member
Author
Updated in the PR. |
lhotari
approved these changes
Nov 19, 2024
lhotari
left a comment
Member
There was a problem hiding this comment.
LGTM. Great improvement! Thanks for the contribution @thetumbled
lhotari
reviewed
Nov 19, 2024
lhotari
reviewed
Nov 19, 2024
dao-jun
approved these changes
Nov 20, 2024
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
15 tasks
codelipenghui
added a commit
to codelipenghui/incubator-pulsar
that referenced
this pull request
Jun 19, 2025
…sage queue (apache#23611)" This reverts commit fcd4436.
codelipenghui
added a commit
to codelipenghui/incubator-pulsar
that referenced
this pull request
Jun 19, 2025
…sage queue (apache#23611)" This reverts commit fcd4436.
4 tasks
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 19, 2025
…upation of the delayed message queue (apache#23611)" (apache#24429) (cherry picked from commit f962d22)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 30, 2025
…upation of the delayed message queue (apache#23611)" (apache#24429) (cherry picked from commit f962d22)
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Delayed queue consume a lot of memory to store the message id. We can reduce the memory occupation with new data structure simillar to #23601.
Modifications
Use new data structure to reduce memory occupation of the delayed message queue,
InMemoryDelayedDeliveryTracker.List some experiment data with following test code:
Produce 1kw entries with 1k ledgers, with the speed of 1 msg/ms.
Original data structure: TripleLongPriorityQueue

It store the info in the direct memory, we can call
queue.bytesCapacity()to get the size of memory it take.So, TripleLongPriorityQueue take up 240MB.
New data structure:

Long2ObjectSortedMap<Long2ObjectMap<Roaring64Bitmap>>It store the data in heap, so we can use
jmapto dump the memory to analyze.So, it take up only 11MB, down to only 11/240=4.5% of the original size!
Verifying this change
(Please pick either of the following options)
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: thetumbled#65