[improve][client] PIP-393: Support configuring NegativeAckPrecisionBitCnt while building consumer.#23804
Merged
thetumbled merged 3 commits intoJan 3, 2025
Conversation
thetumbled
requested review from
Demogorgon314,
codelipenghui,
coderzc,
crossoverJie,
nodece and
poorbarcode
January 3, 2025 06:33
crossoverJie
approved these changes
Jan 3, 2025
nodece
approved these changes
Jan 3, 2025
poorbarcode
reviewed
Jan 3, 2025
poorbarcode
left a comment
Contributor
There was a problem hiding this comment.
How about adding a test for this change?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23804 +/- ##
============================================
+ Coverage 73.57% 74.24% +0.66%
+ Complexity 32624 31819 -805
============================================
Files 1877 1853 -24
Lines 139502 143453 +3951
Branches 15299 16290 +991
============================================
+ Hits 102638 106504 +3866
+ Misses 28908 28576 -332
- Partials 7956 8373 +417
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
reviewed
Jan 3, 2025
Member
Author
Added. |
poorbarcode
approved these changes
Jan 3, 2025
lhotari
approved these changes
Jan 3, 2025
Member
|
@thetumbled Please don't add |
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
Jan 23, 2025
…tCnt while building consumer. (apache#23804)
2 tasks
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…tCnt while building consumer. (apache#23804)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation PR for PIP-393: #23601.
Motivation
PR #23600 has implemented most of the logic, but lack of support for configuring
NegativeAckPrecisionBitCntby mistake.Modifications
Add support for configuring
NegativeAckPrecisionBitCntwhile building consumer.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: thetumbled#68