[fix][broker] Apply dispatcherMaxReadSizeBytes also for replay reads for Shared and Key_Shared subscriptions#23894
Merged
Conversation
This was referenced Jan 24, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23894 +/- ##
============================================
+ Coverage 73.57% 74.16% +0.59%
+ Complexity 32624 32212 -412
============================================
Files 1877 1854 -23
Lines 139502 143644 +4142
Branches 15299 16320 +1021
============================================
+ Hits 102638 106539 +3901
+ Misses 28908 28719 -189
- Partials 7956 8386 +430
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
lhotari
force-pushed
the
lh-limit-replay-messages-by-size
branch
from
January 25, 2025 09:02
c8a23a0 to
6d65d41
Compare
Member
Author
|
@heesung-sn This PR has been rebased now. Please review |
lhotari
requested review from
BewareMyPower,
Technoboy-,
crossoverJie,
eolivelli,
equanz,
nicoloboschi,
poorbarcode,
shibd and
thetumbled
January 25, 2025 13:15
heesung-sohn
approved these changes
Jan 25, 2025
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…for Shared and Key_Shared subscriptions (apache#23894)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23505
Motivation
See #23505. It is expected that dispatcherMaxReadSizeBytes also limits replay queue reads. Replay reads are currently unbounded in byte size, which is unexpected behavior.
Modifications
org.apache.bookkeeper.mledger.ManagedCursor#applyMaxSizeCapalso in replay queue readsDocumentation
docdoc-requireddoc-not-neededdoc-complete