Skip to content

[fix][broker] Apply dispatcherMaxReadSizeBytes also for replay reads for Shared and Key_Shared subscriptions#23894

Merged
lhotari merged 2 commits into
apache:masterfrom
lhotari:lh-limit-replay-messages-by-size
Jan 27, 2025
Merged

[fix][broker] Apply dispatcherMaxReadSizeBytes also for replay reads for Shared and Key_Shared subscriptions#23894
lhotari merged 2 commits into
apache:masterfrom
lhotari:lh-limit-replay-messages-by-size

Conversation

@lhotari

@lhotari lhotari commented Jan 24, 2025

Copy link
Copy Markdown
Member

Fixes #23505

Motivation

See #23505. It is expected that dispatcherMaxReadSizeBytes also limits replay queue reads. Replay reads are currently unbounded in byte size, which is unexpected behavior.

Modifications

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@codecov-commenter

codecov-commenter commented Jan 24, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.16%. Comparing base (bbc6224) to head (6d65d41).
⚠️ Report is 1757 commits behind head on master.

Files with missing lines Patch % Lines
...sistent/PersistentDispatcherMultipleConsumers.java 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23894      +/-   ##
============================================
+ Coverage     73.57%   74.16%   +0.59%     
+ Complexity    32624    32212     -412     
============================================
  Files          1877     1854      -23     
  Lines        139502   143644    +4142     
  Branches      15299    16320    +1021     
============================================
+ Hits         102638   106539    +3901     
+ Misses        28908    28719     -189     
- Partials       7956     8386     +430     
Flag Coverage Δ
inttests 26.69% <42.85%> (+2.11%) ⬆️
systests 23.13% <28.57%> (-1.20%) ⬇️
unittests 73.69% <57.14%> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...sistent/PersistentDispatcherMultipleConsumers.java 74.38% <57.14%> (+0.05%) ⬆️

... and 1027 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari
lhotari force-pushed the lh-limit-replay-messages-by-size branch from c8a23a0 to 6d65d41 Compare January 25, 2025 09:02
@lhotari

lhotari commented Jan 25, 2025

Copy link
Copy Markdown
Member Author

@heesung-sn This PR has been rebased now. Please review

@lhotari
lhotari merged commit 11a615e into apache:master Jan 27, 2025
lhotari added a commit that referenced this pull request Jan 27, 2025
…for Shared and Key_Shared subscriptions (#23894)

(cherry picked from commit 11a615e)
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Redelivering messages doesn't take dispatcherMaxReadSizeBytes into account in Shared and Key_Shared subscriptions

3 participants