Replace Collections.sort(list) with list.sort() to support earlier jdk-version than jdk-1.8.0_20 - #24
Merged
Merged
Conversation
…k-version than jdk-1.8.0_20
|
CLA is valid! |
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
massakam
pushed a commit
to massakam/pulsar
that referenced
this pull request
Aug 6, 2020
[Issue 3] Support authentication
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
…ucer [issue:23]Use golangci-lint to format the code for the master branch run golangci-lint and format the code for the master branch.
hangc0276
referenced
this pull request
in hangc0276/pulsar
May 26, 2021
* Kafka coordinator service (part 1): Add GroupMetadata and MemberMetadata *Motivation* Import Kafka coordinator implementation. This is the first part to introduce GroupMetadata and MemberMetadata. * Group coordindator part 2 * Implement Group Coordinator * Port Kafka timer classes *Motivation* Need to port Kafka's coordinator algorithm. It requires using Kafka's timer and deplayed operations. * Port delayed operations implementation from Kafka * Fix checkstyle and findbugs * Add GroupMetadataManagerTest * Add offset metadata to group metadata *Motivation* Add the support for offsets
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
jdk version before 1.8.0_20 calls set() on iterator while performing
Collections.sort()which throwsUnsupportedOperationException. So, replacingCollections.sort()withlist.sort()Modifications
Replacing
Collections.sort()withlist.sort()Result
It will fix
java.lang.UnsupportedOperationExceptionwhile sorting list.