Skip to content

[fix][ml] Return 1 when bytes size is 0 or negative for entry count estimation #24131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhotari merged 1 commit into from
Mar 26, 2025
Merged

[fix][ml] Return 1 when bytes size is 0 or negative for entry count estimation #24131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/EntryCountEstimator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ static int internalEstimateEntryCountByBytesSize(int maxEntries, long maxSizeByt
Long lastLedgerId, long lastLedgerTotalEntries,
long lastLedgerTotalSize) {
if (maxSizeBytes <= 0) {
// If the specified maximum size is invalid (e.g., non-positive), return 0
return 0;
// If the specified maximum size is invalid (e.g., non-positive), return 1
return 1;
}

// If the maximum size is Long.MAX_VALUE, return the maximum number of entries
Expand Down
8 changes: 7 additions & 1 deletion managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/EntryCountEstimatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,13 @@ private int estimateEntryCountByBytesSize(long maxSizeBytes) {
@Test
public void testZeroMaxSize() {
int result = estimateEntryCountByBytesSize(0);
assertEquals(result, 0, "Should return 0 when max size is 0");
assertEquals(result, 1, "Should return 1 when max size is 0");
}

@Test
public void testNegativeMaxSize() {
int result = estimateEntryCountByBytesSize(-1);
assertEquals(result, 1, "Should return 1 when max size is negative");
}

@Test
Expand Down