Skip to content

[fix][test] Fix flaky ManagedCursorTest.testLastActiveAfterResetCursor and disable failing SchemaTest #24261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhotari merged 3 commits into from
May 7, 2025
Merged

[fix][test] Fix flaky ManagedCursorTest.testLastActiveAfterResetCursor and disable failing SchemaTest #24261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d98aa10
[fix][ml] Update last active before completing the callback
lhotari May 7, 2025
abf36b5
Add delay
lhotari May 7, 2025
04cf6db
Disable consistenly failing test
lhotari May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1460,8 +1460,8 @@ public void operationComplete() {
ledger.getName(), newReadPosition, name);
}
}
callback.resetComplete(newReadPosition);
updateLastActive();
callback.resetComplete(newReadPosition);
}

@Override
Expand Down
3 changes: 3 additions & 0 deletions managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1004,6 +1004,9 @@ void testLastActiveAfterResetCursor() throws Exception {

long lastActive = cursor.getLastActive();

// ensure that the next last active time will be greater than the current one
Thread.sleep(1L);

cursor.asyncResetCursor(lastPosition, false, new AsyncCallbacks.ResetCursorCallback() {
@Override
public void resetComplete(Object ctx) {
Expand Down
3 changes: 2 additions & 1 deletion pulsar-broker/src/test/java/org/apache/pulsar/schema/SchemaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1528,7 +1528,8 @@ public SchemaStorageFormat.SchemaLocator deserialize(String path, byte[] content
producer.close();
}

@Test
// This test fails consistently, disabling until it is fixed. Issue https://github.com/apache/pulsar/issues/24262
@Test(enabled = false)
public void testPendingQueueSizeIfIncompatible() throws Exception {
final String namespace = BrokerTestUtil.newUniqueName(PUBLIC_TENANT + "/ns");
admin.namespaces().createNamespace(namespace, Sets.newHashSet(CLUSTER_NAME));
Expand Down