Skip to content

[improve][broker] add warn log when the delayedMessagesCount is incorrect.#24460

Merged
thetumbled merged 1 commit into
apache:masterfrom
thetumbled:ImproveAddCheckForDelayedMessagesCount
Jun 30, 2025
Merged

[improve][broker] add warn log when the delayedMessagesCount is incorrect.#24460
thetumbled merged 1 commit into
apache:masterfrom
thetumbled:ImproveAddCheckForDelayedMessagesCount

Conversation

@thetumbled

@thetumbled thetumbled commented Jun 25, 2025

Copy link
Copy Markdown
Member

Motivation

#24430 (comment)

Add check for whether the delayedMessagesCount is correct.

Modifications

Add warn log.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@thetumbled thetumbled requested a review from lhotari June 25, 2025 04:03
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Jun 25, 2025
@codelipenghui codelipenghui added this to the 4.1.0 milestone Jun 28, 2025
@codelipenghui

Copy link
Copy Markdown
Contributor

/pulsarbot run-failure-checks

@codecov-commenter

codecov-commenter commented Jun 28, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.28%. Comparing base (bbc6224) to head (ff519ef).
Report is 1181 commits behind head on master.

Files with missing lines Patch % Lines
...broker/delayed/InMemoryDelayedDeliveryTracker.java 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24460      +/-   ##
============================================
+ Coverage     73.57%   74.28%   +0.70%     
- Complexity    32624    32737     +113     
============================================
  Files          1877     1868       -9     
  Lines        139502   145505    +6003     
  Branches      15299    16644    +1345     
============================================
+ Hits         102638   108087    +5449     
+ Misses        28908    28856      -52     
- Partials       7956     8562     +606     
Flag Coverage Δ
inttests 26.87% <0.00%> (+2.28%) ⬆️
systests 23.35% <0.00%> (-0.98%) ⬇️
unittests 73.76% <0.00%> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...broker/delayed/InMemoryDelayedDeliveryTracker.java 88.77% <0.00%> (+0.63%) ⬆️

... and 1080 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thetumbled thetumbled merged commit 32efd3e into apache:master Jun 30, 2025
72 of 78 checks passed
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
…rect. (apache#24460)

Co-authored-by: thetumbled <fengwenzhi.max@bigo.sg>
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
…rect. (apache#24460)

Co-authored-by: thetumbled <fengwenzhi.max@bigo.sg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants