[improve][broker] Implement PIP-430 Pulsar Broker cache improvements - #24623
Merged
Conversation
github-actions
Bot
added
PIP
doc
lhotari
marked this pull request as draft
August 13, 2025 11:51
…dCount to broker.conf
Member
Author
|
Here's the JMH results for the latest changes. The new Here's a visualization of the results: One interesting detail is that ActiveManagedCursorContainerImpl's algorithm would be faster than ManagedCursorContainer's algorithm for tracking the slowest cursor, assuming that most cursors are moving forward (which is the case). |
lhotari
marked this pull request as ready for review
August 14, 2025 11:44
Member
Author
|
The recently added "experimental" test case The with PIP-430 defaults, Cache hits 98.56%, Cache misses 1.44% : with with The results vary quite a lot and these are values from single runs. However, it demonstrates a significant improvement in reducing the amount of cache misses in rolling restarts when PIP-430 defaults are used. |
Member
Author
|
Test logging was slightly impacting the results (I noticed it with async-profiler) and I made changes to configure Log4J logging in tests so that it can be diverted to file based logging instead of default console logging. The results are very similar on Dell XPS 2019 i9-9980HK (on Linux):
detailed:
|
Member
Author
|
This test is flaky, will need to address it. |
Member
Author
|
I also ran the test run on GCP on e2-highcpu-8 VM. The base VM setup was done using these instructions.
|
pdolif
reviewed
Aug 22, 2025
…esMillis to conf files and PIP doc
merlimat
approved these changes
Aug 28, 2025
merlimat
left a comment
merlimat
left a comment
Contributor
There was a problem hiding this comment.
The improvements looks super-impressive! Having the micro-benchmarks make a great case.
Only minor comments
Member
Author
|
While doing some validation, I noticed that Pulsar has a long time issue that consumers aren't able to keep with producers even when there are available resources unless I created #24695 about this. |
Closed
2 tasks
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Demogorgon314
added a commit
to Demogorgon314/kop
that referenced
this pull request
Apr 15, 2026
### Motivation apache/pulsar#24623: Updated: ``` public static EntryImpl create(Position position, ByteBuf data) ``` to ``` public static EntryImpl create(Position position, ByteBuf data, int expectedReadCount) ``` apache/pulsar#24427: Updated: ``` CompletableFuture<Void> updateTopicPoliciesAsync(TopicName topicName, TopicPolicies policies); ``` to ``` CompletableFuture<Void> updateTopicPoliciesAsync(TopicName topicName, boolean isGlobalPolicy, boolean skipUpdateWhenTopicPolicyDoesntExist, Consumer<TopicPolicies> policyUpdater); ``` ### Modifications Fix build issue caused by upstream interface changes
lhotari
added a commit
that referenced
this pull request
Jun 12, 2026
…arMockBookKeeper Partial cherry-pick of the testmocks changes from 490ba0c ([improve][broker] Implement PIP-430 Pulsar Broker cache improvements (#24623)), without the JFR read event interceptor parts which aren't needed on branch-4.0. Required so that CompactionTest compiles after cherry-picking ded1e42d352 (#25998), which uses PulsarMockBookKeeper.setDefaultReadEntriesDelayMillis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16421
Fixes #24656
Motivation
This is the 2nd implementation PR for "PIP-430: Pulsar Broker cache improvements: refactoring eviction and adding a new cache strategy based on expected read count"
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete