[improve][client]Add null check for Pulsar client clock configuration - #24848
Merged
Conversation
Contributor
Author
|
BTW, For custom clock implementations, if the |
lhotari
approved these changes
Oct 14, 2025
dao-jun
approved these changes
Oct 20, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24848 +/- ##
============================================
- Coverage 74.36% 74.02% -0.34%
+ Complexity 33856 32641 -1215
============================================
Files 1913 1913
Lines 149280 152228 +2948
Branches 17324 18163 +839
============================================
+ Hits 111012 112690 +1678
- Misses 29445 30515 +1070
- Partials 8823 9023 +200
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Technoboy-
approved these changes
Oct 27, 2025
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 29, 2025
…apache#24848) (cherry picked from commit 54db7f2) (cherry picked from commit fb1b2a5)
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 29, 2025
…apache#24848) (cherry picked from commit 54db7f2) (cherry picked from commit 79784c0)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 30, 2025
…apache#24848) (cherry picked from commit 54db7f2) (cherry picked from commit 79784c0)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Oct 30, 2025
…apache#24848) (cherry picked from commit 54db7f2)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
…apache#24848) (cherry picked from commit 54db7f2) (cherry picked from commit fb1b2a5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when setting a clock for the Pulsar client, there is no null check for the clock parameter. This can cause a NullPointerException when sending messages if a null clock is passed.1
Modifications
This PR adds a null check for the clock parameter to provide a clear error message and prevent NPEs.
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: 3pacccccc#26