[fix][test]fix flaky SimpleProducerConsumerTest.testReceiveAsyncCompletedWhenClosing - #24858
Merged
Conversation
Denovo1998
suggested changes
Oct 16, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24858 +/- ##
=============================================
+ Coverage 38.49% 74.15% +35.65%
- Complexity 13160 33437 +20277
=============================================
Files 1856 1913 +57
Lines 145149 149915 +4766
Branches 16844 17521 +677
=============================================
+ Hits 55880 111172 +55292
+ Misses 81652 29873 -51779
- Partials 7617 8870 +1253
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Technoboy-
approved these changes
Oct 28, 2025
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 29, 2025
…etedWhenClosing (apache#24858) (cherry picked from commit 1ca1797) (cherry picked from commit ec89455)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
…etedWhenClosing (apache#24858) (cherry picked from commit 1ca1797) (cherry picked from commit ec89455)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24850
Motivation
The test
testReceiveAsyncCompletedWhenClosingwas experiencing concurrency race conditions that caused flaky test failures. The issue occurred due to unpredictable timing between two operations:consumer.receiveAsync()orbatchReceiveAsync()consumer.close()Expected behavior:
Flaky scenario:
close()executes before receiveAsync(), the subsequentreceiveAsync()call immediately returns aCompletableFuturethat completes with aPulsarClientExceptioncontaining the message "Consumer already closed". This differs from the expected interruption behavior and causes the test assertion to fail.Modifications
ensure
consumer.receiveAsync()happens beforeconsumer.close()Solution
Added proper synchronization using CountDownLatch to ensure:
The async operation (receiveAsync/batchReceiveAsync) starts first
The close() operation executes only after the async operation has begun
Verifying this change
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: 3pacccccc#27