Skip to content

[fix][broker]Stop to retry to read entries if the replicator has terminated - #24880

Merged
Technoboy- merged 2 commits into
apache:masterfrom
poorbarcode:fix/replicator_read_more_entries
Oct 24, 2025
Merged

[fix][broker]Stop to retry to read entries if the replicator has terminated#24880
Technoboy- merged 2 commits into
apache:masterfrom
poorbarcode:fix/replicator_read_more_entries

Conversation

@poorbarcode

@poorbarcode poorbarcode commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Motivation

If a scheduled replication reading task is waiting to be executed[1] when a geo replicator is terminating, it will keep retrying to read entries.

[1]: a scheduled replication reading task is waiting to be executed

    protected void readMoreEntries() {
        if (!hasPendingRead()) {
            // Replicator may leave a delayed task here when it is terminating
            topic.getBrokerService().executor().schedule(
                    () -> readMoreEntries(), MESSAGE_RATE_BACKOFF_MS, TimeUnit.MILLISECONDS);
            return;
        } 
}

Modifications

Stop trying to read entries if a replicator has terminated

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@poorbarcode

Copy link
Copy Markdown
Contributor Author

/pulsarbot rerun-failure-checks

@Technoboy-

Copy link
Copy Markdown
Contributor

/pulsarbot rerun-failure-checks

@Technoboy-
Technoboy- merged commit 313ae97 into apache:master Oct 24, 2025
95 of 98 checks passed
lhotari pushed a commit that referenced this pull request Oct 28, 2025
lhotari pushed a commit that referenced this pull request Oct 28, 2025
lhotari pushed a commit that referenced this pull request Oct 28, 2025
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Oct 29, 2025
…minated (apache#24880)

(cherry picked from commit 313ae97)
(cherry picked from commit 3ecbe8c)
priyanshu-ctds pushed a commit to datastax/pulsar that referenced this pull request Oct 29, 2025
…minated (apache#24880)

(cherry picked from commit 313ae97)
(cherry picked from commit 0d35aca)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Oct 30, 2025
…minated (apache#24880)

(cherry picked from commit 313ae97)
(cherry picked from commit 0d35aca)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 6, 2025
…minated (apache#24880)

(cherry picked from commit 313ae97)
(cherry picked from commit 3ecbe8c)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request May 13, 2026
…minated (apache#24880)

(cherry picked from commit 313ae97)
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants