[improve][ci] Replace PULSARBOT_TOKEN with GITHUB_TOKEN configured with permissions - #24916
Merged
lhotari merged 1 commit intoOct 29, 2025
Conversation
…th GitHub Actions permissions
dao-jun
approved these changes
Oct 29, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24916 +/- ##
============================================
+ Coverage 74.21% 74.28% +0.06%
+ Complexity 33820 33480 -340
============================================
Files 1913 1913
Lines 149328 149328
Branches 17334 17334
============================================
+ Hits 110825 110926 +101
+ Misses 29636 29562 -74
+ Partials 8867 8840 -27
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
Oct 29, 2025
- follow up on apache#24916 - If the permission isn't specified, there will be no permission - https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#defining-access-for-the-github_token-scopes
4 tasks
Member
Author
|
There wasn't sufficient permissions. I made a follow-up in #24918, please review. |
Member
Author
It wasn't a problem with the permissions, but a problem in pulsarbot that came up in testing. No need for the follow-up. |
guptas6est
pushed a commit
to Nordix/pulsar
that referenced
this pull request
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The use of
PULSARBOT_TOKENsecret is unnecessary and should be replaced withGITHUB_TOKENthat is configured with sufficient permissions in the workflow file.Modifications
GITHUB_TOKENGITHUB_TOKENto pulsarbot actionDocumentation
docdoc-requireddoc-not-neededdoc-complete