Skip to content

[fix][broker] ExtensibleLoadManager: handle SessionReestablished and Reconnected events to re-register broker metadata #24932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhotari merged 1 commit into from
Nov 3, 2025
Merged

[fix][broker] ExtensibleLoadManager: handle SessionReestablished and Reconnected events to re-register broker metadata #24932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ...ker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/BrokerRegistryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
import org.apache.pulsar.metadata.api.Notification;
import org.apache.pulsar.metadata.api.NotificationType;
import org.apache.pulsar.metadata.api.extended.CreateOption;
import org.apache.pulsar.metadata.api.extended.SessionEvent;

/**
* The broker registry impl, base on the LockManager.
Expand Down Expand Up @@ -112,6 +113,7 @@ public synchronized void start() throws PulsarServerException {
throw new PulsarServerException("Cannot start the broker registry in state " + state.get());
}
pulsar.getLocalMetadataStore().registerListener(this::handleMetadataStoreNotification);
pulsar.getLocalMetadataStore().registerSessionListener(this::handleMetadataSessionEvent);
try {
this.registerAsync().get(conf.getMetadataStoreOperationTimeoutSeconds(), TimeUnit.SECONDS);
} catch (ExecutionException | InterruptedException | TimeoutException e) {
Expand Down Expand Up @@ -282,6 +284,18 @@ private void handleMetadataStoreNotification(Notification t) {
}
}

private void handleMetadataSessionEvent(SessionEvent event) {
if (!this.isStarted()) {
return;
}
if (log.isDebugEnabled()) {
log.debug("Handle metadata session event: [{}]", event);
}
if (event == SessionEvent.SessionReestablished || event == SessionEvent.Reconnected) {
this.registerAsyncWithRetries();
}
}

@VisibleForTesting
protected static boolean isVerifiedNotification(Notification t) {
return t.getPath().startsWith(LOADBALANCE_BROKERS_ROOT + "/")
Expand Down
4 changes: 2 additions & 2 deletions pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ZkSessionExpireTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,11 +202,11 @@ public void testTopicUnloadAfterSessionRebuild(boolean enableSystemTopic, Class
metadataZKProxy.unRejectAllConnections();
Awaitility.await().untilAsserted(() -> {
Set<String> availableBrokers1 = getAvailableBrokers(pulsar1);
Set<String> availableBrokers2 = getAvailableBrokers(pulsar1);
Set<String> availableBrokers2 = getAvailableBrokers(pulsar2);
log.info("Available brokers 1: {}", availableBrokers1);
log.info("Available brokers 2: {}", availableBrokers2);
assertEquals(availableBrokers1.size(), 2);
assertEquals(availableBrokers1.size(), 2);
assertEquals(availableBrokers2.size(), 2);
});

// Verify: the topic on broker-1 will be unloaded.
Expand Down
Loading