Skip to content

[fix][client] PIP-84: Skip processing a message in the message listener if the consumer epoch is no longer valid - #25007

Merged
lhotari merged 1 commit into
apache:masterfrom
lhotari:lh-implement-pip-84-for-message-listeners
Nov 24, 2025
Merged

[fix][client] PIP-84: Skip processing a message in the message listener if the consumer epoch is no longer valid#25007
lhotari merged 1 commit into
apache:masterfrom
lhotari:lh-implement-pip-84-for-message-listeners

Conversation

@lhotari

@lhotari lhotari commented Nov 21, 2025

Copy link
Copy Markdown
Member

Motivation

PIP-84: Pulsar client: Redeliver command add epoch was implemented for Pulsar 2.10 with PR #10478, however it missed handling of the usage of message listeners.
When message listeners are used, the messages will get buffered in the listener's executor. This case wasn't covered.

Modifications

Before processing a message in the message listener, add a similar check that is done for messages before processing while using the receive API.

Tests TBD

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.2.0 milestone Nov 21, 2025
@lhotari lhotari self-assigned this Nov 21, 2025
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Nov 21, 2025
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.29%. Comparing base (807dcaf) to head (314004f).

Files with missing lines Patch % Lines
...va/org/apache/pulsar/client/impl/ConsumerBase.java 28.57% 4 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #25007      +/-   ##
============================================
+ Coverage     74.27%   74.29%   +0.02%     
- Complexity    33563    34057     +494     
============================================
  Files          1920     1920              
  Lines        150279   150286       +7     
  Branches      17448    17451       +3     
============================================
+ Hits         111618   111657      +39     
+ Misses        29768    29733      -35     
- Partials       8893     8896       +3     
Flag Coverage Δ
inttests 26.54% <0.00%> (?)
systests 22.84% <14.28%> (-0.01%) ⬇️
unittests 73.81% <28.57%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...va/org/apache/pulsar/client/impl/ConsumerBase.java 74.66% <28.57%> (-0.55%) ⬇️

... and 106 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari
lhotari merged commit 9deee37 into apache:master Nov 24, 2025
73 of 76 checks passed
lhotari added a commit that referenced this pull request Nov 25, 2025
…er if the consumer epoch is no longer valid (#25007)

(cherry picked from commit 9deee37)
lhotari added a commit that referenced this pull request Nov 25, 2025
…er if the consumer epoch is no longer valid (#25007)

(cherry picked from commit 9deee37)
lhotari added a commit that referenced this pull request Nov 27, 2025
…er if the consumer epoch is no longer valid (#25007)

(cherry picked from commit 9deee37)
ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Dec 1, 2025
…er if the consumer epoch is no longer valid (apache#25007)

(cherry picked from commit 9deee37)
(cherry picked from commit e5368c0)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Dec 2, 2025
…er if the consumer epoch is no longer valid (apache#25007)

(cherry picked from commit 9deee37)
(cherry picked from commit e9f49f2)
ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Dec 2, 2025
…er if the consumer epoch is no longer valid (apache#25007)

(cherry picked from commit 9deee37)
(cherry picked from commit e5368c0)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Dec 2, 2025
…er if the consumer epoch is no longer valid (apache#25007)

(cherry picked from commit 9deee37)
(cherry picked from commit e9f49f2)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Dec 3, 2025
…er if the consumer epoch is no longer valid (apache#25007)

(cherry picked from commit 9deee37)
Rutuja-IBM pushed a commit to datastax/pulsar that referenced this pull request Feb 9, 2026
…er if the consumer epoch is no longer valid (apache#25007)

(cherry picked from commit 9deee37)
(cherry picked from commit e9f49f2)
Rutuja-IBM pushed a commit to datastax/pulsar that referenced this pull request Feb 9, 2026
…er if the consumer epoch is no longer valid (apache#25007)

(cherry picked from commit 9deee37)
(cherry picked from commit e9f49f2)
Rutuja-IBM pushed a commit to datastax/pulsar that referenced this pull request Feb 12, 2026
…er if the consumer epoch is no longer valid (apache#25007)

(cherry picked from commit 9deee37)
(cherry picked from commit e9f49f2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants