[fix][test] Fix flaky ExtensibleLoadManagerImplTest.testLoadBalancerServiceUnitTableViewSyncer - #25378
Merged
lhotari merged 1 commit intoMar 21, 2026
Conversation
…erviceUnitTableViewSyncer The test updates the loadBalancerServiceUnitTableViewSyncer dynamic config and immediately triggers leader transitions. If the config hasn't propagated to the broker's ServiceConfiguration by the time the leader callback fires, isLoadBalancerServiceUnitTableViewSyncerEnabled() returns false and the syncer is never activated. Fix by waiting for the dynamic config to propagate to both brokers before triggering leader transitions. This ensures the leader callback sees the updated config and activates the syncer deterministically. Also apply the same pattern to the cleanup section where the config is deleted.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25378 +/- ##
============================================
+ Coverage 72.52% 72.70% +0.18%
+ Complexity 34275 33852 -423
============================================
Files 1927 1954 +27
Lines 154339 154791 +452
Branches 17683 17730 +47
============================================
+ Hits 111935 112544 +609
+ Misses 33389 33208 -181
- Partials 9015 9039 +24
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
lhotari
approved these changes
Mar 21, 2026
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2026
…erviceUnitTableViewSyncer (apache#25378) (cherry picked from commit 4e7ee94) (cherry picked from commit c71ccc7)
2 tasks
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 27, 2026
…erviceUnitTableViewSyncer (apache#25378) (cherry picked from commit 4e7ee94)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flaky test failure
Summary
ExtensibleLoadManagerImplTest.testLoadBalancerServiceUnitTableViewSyncerby making it deterministic instead of time-dependent.loadBalancerServiceUnitTableViewSyncerdynamic config and immediately triggers leader transitions. If the config hasn't propagated to the broker'sServiceConfigurationby the time the leader callback fires,isLoadBalancerServiceUnitTableViewSyncerEnabled()returns false and the syncer is never activated — causing the 10s Awaitility timeout to expire.isLoadBalancerServiceUnitTableViewSyncerEnabled()) before triggering leader transitions. This ensures the leader callback sees the updated config and activates the syncer deterministically.Documentation
doc-not-needed(Your PR doesn't need any doc update)
Matching PR in forked repository
No response
Tip
Add the labels
ready-to-testandarea/testto trigger the CI.