[fix][test] Fix flaky ExtensibleLoadManagerTest.startBroker timeout - #25500
Merged
nodece merged 1 commit intoApr 9, 2026
Merged
Conversation
Replace ignoreExceptions() with explicit try-catch and logging in the startBroker @BeforeMethod so that errors are visible in test logs while still allowing retries. Increase the Awaitility timeout from 120 to 180 seconds to accommodate broker crash-restart cycles that occur when the ServiceUnitStateTableViewImpl fails to read the compacted ledger.
nodece
approved these changes
Apr 9, 2026
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2026
…pache#25500) (cherry picked from commit 12bcd6b) (cherry picked from commit 6cdc9f7)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 27, 2026
…pache#25500) (cherry picked from commit 12bcd6b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21875
Motivation
Fix flaky
ExtensibleLoadManagerTest.startBrokerthat times out when restarting brokers aftertestStopBrokerortestIsolationPolicy.The root cause is that after a broker is stopped and its container is restarted, the
ServiceUnitStateTableViewImplchannel fails to start due to a compacted ledger read error ("Invalid unknown tag type: 4", a known issue per PIP-429). The broker process crashes and restarts 2-3 times inside the Docker container before succeeding. The previous 120-second timeout was insufficient for this crash-restart cycle.Additionally,
ignoreExceptions()was hiding all errors, making these failures impossible to debug from test logs.Modifications
ignoreExceptions()with explicit try-catch and logging inside the Awaitility condition, so errors are visible in test logs while still allowing retriespulsarClusteris null, rename shadowed variableVerifying this change
This change is already covered by existing integration tests in the
pulsar-loadbalancetest group.Does this pull request potentially affect one of the following parts: