[fix][test] Fix flaky ExtensibleLoadManagerImpl client reconnection tests: PulsarClientException$AlreadyClosedException: Client already closed - #25509
Merged
Conversation
The tests were failing intermittently with:
PulsarClientException$AlreadyClosedException: Client already closed : state = Closed
Root cause: 4 PulsarClient instances were shared across all test methods
via @BeforeClass. Once any client entered the Closed state (e.g. due to
a previous test timeout or incomplete cleanup of Mockito-spied lookup
services), all subsequent tests using that client would fail.
Fix: each test method now creates and closes its own PulsarClient
instances, eliminating shared mutable state between tests.
Contributor
Author
merlimat
approved these changes
Apr 13, 2026
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2026
…ests: PulsarClientException$AlreadyClosedException: Client already closed (apache#25509) (cherry picked from commit bf45974) (cherry picked from commit 3b92e85)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 27, 2026
…ests: PulsarClientException$AlreadyClosedException: Client already closed (apache#25509) (cherry picked from commit bf45974)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests were failing intermittently with:
PulsarClientException$AlreadyClosedException: Client already closed : state = Closed
Root cause: 4 PulsarClient instances were shared across all test methods
via @BeforeClass. Once any client entered the Closed state (e.g. due to
a previous test timeout or incomplete cleanup of Mockito-spied lookup
services), all subsequent tests using that client would fail.
Fix: each test method now creates and closes its own PulsarClient
instances, eliminating shared mutable state between tests.