[fix][ci] Ensure discard_max_bytes is set to 0 only for existing block devices - #25510
Merged
Conversation
nodece
force-pushed
the
fix-discard_max_bytes
branch
from
April 13, 2026 02:16
7654fc9 to
4ad074f
Compare
nodece
changed the title
merlimat
approved these changes
Apr 13, 2026
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2026
…k devices (apache#25510) (cherry picked from commit 089f87f) (cherry picked from commit 4934337)
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
May 27, 2026
…k devices (apache#25510) (cherry picked from commit 089f87f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In CI environments, the following error was observed when attempting to disable discard:
This happens because the script assumes block devices follow the
sd*naming convention, which is not always true (e.g., NVMe or virtual disks). As a result, the glob does not match any files and causes the step to fail.Modifications
/sys/block/sd*/queue/discard_max_byteswith/sys/block/*/queue/discard_max_bytesto support all block device types-f) before applyingteeto avoid errors when the file is not present