[fix][test] Relax BrokerRegistryIntegrationTest broker-close threshold - #25562
Merged
nodece merged 1 commit intoApr 22, 2026
Merged
Conversation
The test (and its BrokerRegistryMetadataStoreIntegrationTest subclass) fail the cleanup method if pulsar.close() takes more than 5 seconds. On slower CI agents the broker shutdown legitimately crosses this boundary (e.g. 10173ms observed), producing spurious failures. The assertion was added as a regression detector for multi-minute hangs (see PR apache#23371). Raising the threshold to 15s still catches those hangs while tolerating normal CI variability.
nodece
approved these changes
Apr 22, 2026
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2026
apache#25562) (cherry picked from commit f26e3ba) (cherry picked from commit de3eb9d)
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
May 6, 2026
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 27, 2026
apache#25562) (cherry picked from commit f26e3ba)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
BrokerRegistryIntegrationTestand its subclassBrokerRegistryMetadataStoreIntegrationTestfail their@AfterClasscleanup method ifpulsar.close()takes more than 5 seconds. On slower CI agents (or for the metadata-store variant), the broker shutdown can legitimately exceed 5 seconds, producing spurious failures.The assertion was originally added by PR #23371 as a regression detector for multi-minute hangs caused by blocked health checks / stuck registrations. A 15-second threshold still catches those hangs but tolerates normal CI variability.
Example failure
Modifications
Raise the cleanup-threshold from 5000ms to 15000ms. Add a comment explaining the intent so future readers understand why the check exists and why it is intentionally loose.
Verifying this change
This change is a trivial rework of an existing test-only assertion and is already covered by existing tests (
BrokerRegistryIntegrationTest,BrokerRegistryMetadataStoreIntegrationTest).Does this pull request potentially affect one of the following parts: