Skip to content

[function] Fix expected health check interval #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srkukarni merged 2 commits into from
Oct 2, 2018
Merged

[function] Fix expected health check interval #2684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ec6ef8
[function] Fix expected health check interval
sijie Sep 30, 2018
0876d9f
Merge remote-tracking branch 'apache/master' into fix_health_check_in…
sijie Oct 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...r-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ public interface RuntimeFactory extends AutoCloseable {
* Create a function container to execute a java instance.
*
* @param instanceConfig java instance config
* @param codeFile code file
* @param expectedHealthCheckInterval expected health check interval in seconds
* @return function container to start/stop instance
*/
Runtime createContainer(
Expand Down
2 changes: 1 addition & 1 deletion ...r-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public void start() throws Exception {
details.getName(), this.instanceConfig.getInstanceId());

runtime = runtimeFactory.createContainer(this.instanceConfig, codeFile, originalCodeFileName,
instanceLivenessCheckFreqMs * 1000);
instanceLivenessCheckFreqMs / 1000);

@jerrypeng jerrypeng Oct 1, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also rename "instanceLivenessCheckFreqMs" since it has "Ms" at the end to indicate its in milliseconds.

@sijie sijie Oct 1, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand your comment here. "instanceLivenessCheckFreqMs" is in milliseconds, and have "ms" at the end is clear. Here we divide it by 1000 to convert it to seconds.

runtime.start();

// monitor function runtime to make sure it is running. If not, restart the function runtime
Expand Down