Skip to content

Close HTTP client connection upon server error or per HTTP spec #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merlimat merged 1 commit into from
Mar 2, 2017
Merged

Close HTTP client connection upon server error or per HTTP spec #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions pulsar-client/src/main/java/com/yahoo/pulsar/client/impl/HttpClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,12 @@
import java.util.concurrent.CompletableFuture;

import io.netty.channel.EventLoopGroup;
import io.netty.handler.codec.http.HttpRequest;
import io.netty.handler.codec.http.HttpResponse;
import io.netty.handler.codec.http.HttpResponseStatus;
import io.netty.handler.ssl.SslContext;
import org.asynchttpclient.*;
import org.asynchttpclient.channel.DefaultKeepAliveStrategy;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand Down Expand Up @@ -70,8 +73,12 @@ protected HttpClient(String serviceUrl, Authentication authentication, EventLoop
confBuilder.setConnectTimeout(connectTimeoutInSeconds * 1000);
confBuilder.setReadTimeout(readTimeoutInSeconds * 1000);
confBuilder.setUserAgent(String.format("Pulsar-Java-v%s", getPulsarClientVersion()));
confBuilder.setKeepAliveStrategy((request, httpRequest, httpResponse) -> {
return !httpResponse.getStatus().equals(HttpResponseStatus.INTERNAL_SERVER_ERROR);
confBuilder.setKeepAliveStrategy(new DefaultKeepAliveStrategy() {
@Override
public boolean keepAlive(Request ahcRequest, HttpRequest request, HttpResponse response) {
// Close connection upon a server error or per HTTP spec
return (response.getStatus().code() / 100 != 5) && super.keepAlive(ahcRequest, request, response);
}
});

if ("https".equals(url.getProtocol())) {
Expand Down