Skip to content

While closing-topic: remove producer from set in separate thread than same set-iterator thread - #32

Merged
merlimat merged 1 commit into
apache:masterfrom
rdhabalia:topic_close
Sep 22, 2016
Merged

While closing-topic: remove producer from set in separate thread than same set-iterator thread#32
merlimat merged 1 commit into
apache:masterfrom
rdhabalia:topic_close

Conversation

@rdhabalia

@rdhabalia rdhabalia commented Sep 22, 2016

Copy link
Copy Markdown
Contributor

Motivation

While closing topic: Closing-topic thread iterates over producers typeof ConcurrentOpenHashSet and try to remove element from same Set and in the same thread, which may cause deadlock. So, we need to remove producer-element from Set in different thread.

Modifications

Remove closed-producer from Set in different thread.

Result

It will avoid possible deadlock on ConcurrentOpenHashSet while closing topic.

@rdhabalia rdhabalia added the type/bug The PR fixed a bug or issue reported a bug label Sep 22, 2016
@rdhabalia rdhabalia added this to the 1.15 milestone Sep 22, 2016
@yahoocla

yahoocla commented Sep 22, 2016

Copy link
Copy Markdown

CLA is valid!

1 similar comment
@yahoocla

yahoocla commented Sep 22, 2016

Copy link
Copy Markdown

CLA is valid!

@merlimat
merlimat merged commit 7d317bd into apache:master Sep 22, 2016
@rdhabalia
rdhabalia deleted the topic_close branch November 11, 2016 23:02
sijie pushed a commit to sijie/pulsar that referenced this pull request Mar 4, 2018
@srkukarni @sijie
Nomenclature (apache#32)
4dd4089 
* Create pulsar-functions module (#1)

* Create pulsar-functions module

* rename `sdk` package to `api`

* Added the first cut of the Java interface for Pulsar functions (#2)

* Made our function hierarchy match pulsar's

* Replace cluster with tenant
hangc0276 pushed a commit to hangc0276/pulsar that referenced this pull request May 26, 2021
@jiazhai @sijie
[Issue apache#32] Consumer group cluster (apache#52)
a96d0a4 
fix Issue apache#32  
Make Consumer Group work distributed.
Add unit test for multi-brokers.
Pass tests  for 2 brokers with `bin/kop kafka-broker`
@xiaotongwang1 xiaotongwang1 mentioned this pull request Aug 4, 2021
Closed
@ZHr-UChiHa ZHr-UChiHa mentioned this pull request Jun 3, 2023
Open
2 tasks
tisonkun pushed a commit to tisonkun/pulsar that referenced this pull request Jul 12, 2023
@syhily @reswqa
[FLINK-31101][Test] Drop the use of JUnit 5 assertions and mockito.
2c43292 
This closes apache#32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merlimat merlimat merlimat approved these changes

Assignees

@rdhabalia rdhabalia

Labels

type/bug The PR fixed a bug or issue reported a bug

Projects

None yet

Milestone

1.15

Development

Successfully merging this pull request may close these issues.

3 participants

@rdhabalia @yahoocla @merlimat