Skip to content

Remove two unused shaded modules - #3559

Merged
merlimat merged 1 commit into
apache:masterfrom
sijie:remove_runtime-shaded
Feb 9, 2019
Merged

Remove two unused shaded modules#3559
merlimat merged 1 commit into
apache:masterfrom
sijie:remove_runtime-shaded

Conversation

@sijie

@sijie sijie commented Feb 9, 2019

Copy link
Copy Markdown
Member

Motivation

There are a few shaded modules introduced when functions was introduced.
They are not needed anymore. We should remove them.

Modifications

Remote those unused modules.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

*Motivation*

There are a few shaded modules introduced when functions was introduced.
They are not needed anymore. We should remove them.

*Modifications*

Remote those unused modules.
@sijie sijie added area/build type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use labels Feb 9, 2019
@sijie sijie self-assigned this Feb 9, 2019
@sijie

sijie commented Feb 9, 2019

Copy link
Copy Markdown
Member Author

run java8 tests

@merlimat
merlimat merged commit f11e994 into apache:master Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants