[pulsar-broker] add support for connection expiry and renew-cnx - #3705
[pulsar-broker] add support for connection expiry and renew-cnx#3705rdhabalia wants to merge 2 commits into
Conversation
|
@rdhabalia Since this is not a fix or a trivial change, I'd move this to 2.4.0 rather than 2.3.1 |
merlimat
added
the
type/feature
868912c to
0b1a5db
Compare
|
@rdhabalia do we need this for 2.4.0? or shall move it to 2.5.0? |
|
@rdhabalia I moved this pull request to 2.5.0 since it is idle for a while. If it is needed in 2.4.0, please move it back. |
|
@rdhabalia can you rebase this. |
add support in cpp client Fix tests
|
@aahmed-se I have rebased the PR and it took a while as lot of changes have been merged since this PR was created. |
|
rerun java8 tests |
|
rerun cpp tests |
|
@merlimat this is related to PIP-51. |
|
@rdhabalia I moved this pull request to 2.7.0 since it is idle for a while. If it is needed in 2.6.0, please move it back. |
|
@rdhabalia I moved this pull request to 2.9.0 since it is idle for a while. If it is needed in 2.8.0, please move it back |
|
I think @merlimat have also implemented similar thing later on and didn't get chance to review this PR. So, I will close it. I guess we should review older PR rather creating duplicate one and closing old one. |
5 participants
Motivation
Right now, broker authenticates client only at the time of opening the connection and this connection become valid for it's lifetime and client can produce/consume messages on this connection even though auth-data provided on that connection is expired. So, we want to close/renew such connections which are expired on the broker.
So, right now, broker doesn't close the expired connection and broker-client don't have capability to renew the connection without closing it.
Modification
Add option in broker to renew connection by asking client to resend renewed auth-data without closing the connection. If client fails to send refreshed-valid auth-data then broker closes the connection.
Result
Broker will have capability to check connection expiry after the auth-data is expired and broker can close the expired connection. This feature will be disabled by default.