Skip to content

Expose MessageId as part of Record interface #4237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srkukarni wants to merge 3 commits into from
Closed

Expose MessageId as part of Record interface #4237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbb6038
Expose MessageId as part of Record interface
May 8, 2019
3711eef
Fixed build
May 9, 2019
c132f8b
Fixed build
May 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/Record.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,13 @@ default Optional<String> getKey() {
return Optional.empty();
}

/**
* Return a record id if the record has one associated.
*/
default Optional<byte[]> getRecordId() {
return Optional.empty();
}

/**
* Retrieves the actual data of the record.
*
Expand Down
3 changes: 3 additions & 0 deletions pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/PulsarRecord.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,4 +106,7 @@ public void ack() {
public void fail() {
this.failFunction.run();
}

@Override
public Optional<byte[]> getRecordId() { return Optional.of(message.getMessageId().toByteArray()); }
}