Skip to content

Add messaging integration tests for different subscriptions. - #4352

Merged
merlimat merged 6 commits into
apache:masterfrom
codelipenghui:messaging_integration_test
May 24, 2019
Merged

Add messaging integration tests for different subscriptions.#4352
merlimat merged 6 commits into
apache:masterfrom
codelipenghui:messaging_integration_test

Conversation

@codelipenghui

Copy link
Copy Markdown
Contributor

Motivation

Add integration tests for message send and receive.

Cover different subscriptions:

  • Exclusive
  • Failover
  • Shared
  • Key_Shared

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@codelipenghui codelipenghui changed the title Add messaging integration tests. Add messaging integration tests for different subscriptions. May 23, 2019

@jiazhai jiazhai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codelipenghui for this testing work

@codelipenghui

Copy link
Copy Markdown
Contributor Author

run Java8 Tests

@merlimat

Copy link
Copy Markdown
Contributor

@codelipenghui It's failing on KeySharedSubscriptionTest.testConsumerCrashSendAndReceiveWithHashRangeStickyKeyConsumerSelector which seems to be flaky #4353

@lovelle

lovelle commented May 24, 2019

Copy link
Copy Markdown
Contributor

KeySharedSubscriptionTest.testConsumerCrashSendAndReceiveWithHashRangeStickyKeyConsumerSelector fails on master branch for me.

@codelipenghui

Copy link
Copy Markdown
Contributor Author

Seems this is related to changes here https://github.com/apache/pulsar/pull/4329/files#diff-12d605952d013b598fd881f86c7cdefcL193.
I did some testing and found that this problem occurs when I close two consumers too quickly and if not included #4329 , UT can passed every time. I am trying to find out what the problem is.

@merlimat merlimat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat

Copy link
Copy Markdown
Contributor

Thanks for fixing this. It was indeed a regression in my change.

@codelipenghui

Copy link
Copy Markdown
Contributor Author

run Integration Tests

@codelipenghui

Copy link
Copy Markdown
Contributor Author

run Java8 Tests

@merlimat
merlimat merged commit b161328 into apache:master May 24, 2019
@codelipenghui

Copy link
Copy Markdown
Contributor Author

relate to #4077

@codelipenghui
codelipenghui deleted the messaging_integration_test branch May 19, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants