[pulsar-broker] add cli/admin api to delete bookie-affinity group - #4471
Conversation
|
retest this please |
Fix: get correct available-primary bookie count | cli optional fix test
|
rerun integration tests |
sijie
left a comment
sijie
left a comment
There was a problem hiding this comment.
@Anonymitaet @jennifer88huang can anyone of you help review the documentation for this api endpoint?
| @ApiOperation(hidden = true, value = "Delete the bookie-affinity-group from namespace-local policy.") | ||
| @ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have admin permission"), | ||
| @ApiResponse(code = 404, message = "Namespace does not exist"), | ||
| @ApiResponse(code = 409, message = "Concurrent modification") }) |
There was a problem hiding this comment.
@rdhabalia since you are adding new endpoints, do you mind making sure all the return codes are properly documented? since there are multiple efforts on improving the documentation around this area.
There was a problem hiding this comment.
yes, it seems correct to me.
| @DELETE | ||
| @Path("/{property}/{namespace}/persistence/bookieAffinity") | ||
| @ApiOperation(hidden = true, value = "Delete the bookie-affinity-group from namespace-local policy.") | ||
| @ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have admin permission"), |
Jennifer88huang-zz
left a comment
Jennifer88huang-zz
left a comment
There was a problem hiding this comment.
I have checked description, and there is no issue with it.
Approve from language level. Dev can check the methods and other tech issues.
|
@rdhabalia do we need this issue for 2.4.0? or can we move it to 2.5.0? |
|
yes, we need this one for 2.4 and it's ready to merge as well. |
|
@rdhabalia can you check the review comments from @jennifer88huang and @Anonymitaet ? |
Sure, but I replied to comment and it seems things are expected. Can you please let me know if I am missing anything here to address. |
|
rerun java8 tests |
1 similar comment
|
rerun java8 tests |
|
rerun cpp tests |
5 participants
Motivation
This PR is on top of #4458. It adds support to delete bookie-affinity group using cli/admin api.