WebSocket proxy should not make a consumer/producer when authorization is failed

[yush1ga]

Motivation

Now, websocket proxy make an internal consumer/producer by using a super user role even if authorization is failed. (Although websocket connection is closed.)
It causes some problems.

Modifications

• Changed isAuthorized() to synchronized
• Made producer/consumer creation abstract

Result

Websocket proxy no longer make consumers/producers for unauthorized users.

[rdhabalia]

actually idea behind keeping isAuthorized async to avoid blocking-thread on authorization check. So, can we keep it async and on future-complete we can call createClient(session) so, we can still keep it async and avoid creation of producer/consumer on authorization failure.

[yush1ga]

I returned isAuthorized() to asynchronized and put createClient() in thenApply block.

[yush1ga]

Some tests were failed.
I'm going to cope with it.
The local test has been passed.

[rdhabalia]

do you think it make sense to complete handshake super.onWebSocketConnect(session); after successfully authenticating client, means after calling createClient(session)?

[yush1ga]

As mentioned here, onWebSocketConnect seems to be called after handshake is completed and super.onWebSocketConnect(session) seems to only set member variables.
In addition, as you stated in #98, onWebSocketText(..) gets triggered at server only when server releases thread from onWebSocketConnect().
I think we need not move super.onWebSocketConnect(session).
What do you think?

[rdhabalia]

onWebSocketText(..) gets triggered only when server releases thread from onWebSocketConnect()

It means if we do authorization async then there could be a chance that producer start producing messages even before authorization completed. So, we can keep your previous commit where we do authorization synchronously and it should be faster because we fetch it from ZkCache and get from zk only once.

[yush1ga]

I changed isAuthorized into synchronized again.

[rdhabalia]

👍

[yush1ga]

@merlimat @saandrews
Will you please take a look ?

[merlimat]

👍