[pulsar-admin] add read-timeout to blocked admin-request - #4484
Conversation
|
rerun java8 tests |
| this.worker = new WorkerImpl(root, auth); | ||
| this.schemas = new SchemasImpl(root, auth); | ||
| this.bookies = new BookiesImpl(root, auth); | ||
| long readTimeoutMs = readTimeoutUnit.toMillis(this.readTimeout); |
There was a problem hiding this comment.
I haven't found the line which sets readTimeout in https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java , so readTimeout seems to be set to the default value (60 seconds) for Brokers.
Can you make it configurable in broker.conf?
(I feel 60 seconds is too large for Brokers)
There was a problem hiding this comment.
sure, I will fix it.
sijie
left a comment
sijie
left a comment
There was a problem hiding this comment.
I see some places are using connectTimeoutMs and some places are using readTimeoutMs. Can we be consistent across all the places?
|
ping @rdhabalia |
|
@nkurihar most of the admin-sync call makes blocking zk call so, configured admin-readtimeout as
yes, I have fixed it. |
|
rerun java8 tests |
|
@rdhabalia minor comment: Lines 64 to 65 in a195221 |
|
rerun java8 tests |
|
@rdhabalia do we need this issue for 2.4.0? or can we move it to 2.5.0? |
|
yes, it's ready to merge. |
|
@sijie Please help review again. |
|
@nkurihar can you review and merge it? |
4 participants
Motivation
It fixes #4447 and unblocks broker's admin thread and avoids possible deadlock.